oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

output_all: fix off-by-one error in audio_output_all_check()

Browse Source 
When there are chunks which are not yet finished,
audio_output_all_check() returned the size of its music pipe minus
one.  I can't remember exactly why I subtracted 1 from the return
value, it must have had something to do with a former meaning of this
function.  Now it induces assertion failures.
This commit is contained in:
Max Kellermann
2009-03-12 19:49:10 +01:00
parent d8218cae6b
commit e3b9b57ecd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/output_all.c
View File

@@ -364,7 +364,7 @@ audio_output_all_check(void)
if (!chunk_is_consumed(chunk)) if (!chunk_is_consumed(chunk))
/* at least one output is not finished playing /* at least one output is not finished playing
this chunk */ this chunk */
return music_pipe_size(g_mp) - 1; return music_pipe_size(g_mp);
is_tail = chunk->next == NULL; is_tail = chunk->next == NULL;
if (is_tail) if (is_tail)