From e3b9b57ecdf8c1396d120f1ccee0814a3e119511 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Thu, 12 Mar 2009 19:49:10 +0100 Subject: [PATCH] output_all: fix off-by-one error in audio_output_all_check() When there are chunks which are not yet finished, audio_output_all_check() returned the size of its music pipe minus one. I can't remember exactly why I subtracted 1 from the return value, it must have had something to do with a former meaning of this function. Now it induces assertion failures. --- src/output_all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/output_all.c b/src/output_all.c index a0f90df52..a95ff2d16 100644 --- a/src/output_all.c +++ b/src/output_all.c @@ -364,7 +364,7 @@ audio_output_all_check(void) if (!chunk_is_consumed(chunk)) /* at least one output is not finished playing this chunk */ - return music_pipe_size(g_mp) - 1; + return music_pipe_size(g_mp); is_tail = chunk->next == NULL; if (is_tail)