oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

output/{alsa,osx}: remove comment after PcmExport::Export()

Browse Source 
Returning an empty buffer is a normal result now (since commit
79839db3a3), and doesn't deserve such a
big comment.
This commit is contained in:
Max Kellermann 2019-06-17 22:09:06 +02:00
parent 33f5e03e80
commit ccc96e25d3
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/output/plugins/AlsaOutputPlugin.cxx
View File

@ -873,12 +873,6 @@ AlsaOutput::Play(const void *chunk, size_t size)
const auto e = pcm_export->Export({chunk, size}); const auto e = pcm_export->Export({chunk, size});
if (e.size == 0) if (e.size == 0)
/* the DoP (DSD over PCM) filter converts two frames
at a time and ignores the last odd frame; if there
was only one frame (e.g. the last frame in the
file), the result is empty; to avoid an endless
loop, bail out here, and pretend the one frame has
been played */
return size; return size;
std::unique_lock<Mutex> lock(mutex); std::unique_lock<Mutex> lock(mutex);

6
src/output/plugins/OSXOutputPlugin.cxx
View File

@ -887,12 +887,6 @@ OSXOutput::Play(const void *chunk, size_t size)
#ifdef ENABLE_DSD #ifdef ENABLE_DSD
if (dop_enabled) { if (dop_enabled) {
const auto e = pcm_export->Export({chunk, size}); const auto e = pcm_export->Export({chunk, size});
/* the DoP (DSD over PCM) filter converts two frames
at a time and ignores the last odd frame; if there
was only one frame (e.g. the last frame in the
file), the result is empty; to avoid an endless
loop, bail out here, and pretend the one frame has
been played */
if (e.size == 0) if (e.size == 0)
return size; return size;