From ccc96e25d33e1fc88e6ce6e754f50b359baf9ada Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Mon, 17 Jun 2019 22:09:06 +0200 Subject: [PATCH] output/{alsa,osx}: remove comment after PcmExport::Export() Returning an empty buffer is a normal result now (since commit 79839db3a3b6819eb4d4d8408bc368bf1bc2618e), and doesn't deserve such a big comment. --- src/output/plugins/AlsaOutputPlugin.cxx | 6 ------ src/output/plugins/OSXOutputPlugin.cxx | 6 ------ 2 files changed, 12 deletions(-) diff --git a/src/output/plugins/AlsaOutputPlugin.cxx b/src/output/plugins/AlsaOutputPlugin.cxx index d1a0f7a9d..dcde63300 100644 --- a/src/output/plugins/AlsaOutputPlugin.cxx +++ b/src/output/plugins/AlsaOutputPlugin.cxx @@ -873,12 +873,6 @@ AlsaOutput::Play(const void *chunk, size_t size) const auto e = pcm_export->Export({chunk, size}); if (e.size == 0) - /* the DoP (DSD over PCM) filter converts two frames - at a time and ignores the last odd frame; if there - was only one frame (e.g. the last frame in the - file), the result is empty; to avoid an endless - loop, bail out here, and pretend the one frame has - been played */ return size; std::unique_lock lock(mutex); diff --git a/src/output/plugins/OSXOutputPlugin.cxx b/src/output/plugins/OSXOutputPlugin.cxx index c36a82028..330ada9ca 100644 --- a/src/output/plugins/OSXOutputPlugin.cxx +++ b/src/output/plugins/OSXOutputPlugin.cxx @@ -887,12 +887,6 @@ OSXOutput::Play(const void *chunk, size_t size) #ifdef ENABLE_DSD if (dop_enabled) { const auto e = pcm_export->Export({chunk, size}); - /* the DoP (DSD over PCM) filter converts two frames - at a time and ignores the last odd frame; if there - was only one frame (e.g. the last frame in the - file), the result is empty; to avoid an endless - loop, bail out here, and pretend the one frame has - been played */ if (e.size == 0) return size;