decoder/dsdiff: fix off-by-one buffer overflow

2016-03-06 23:28:29 +01:00 · 2016-03-06 23:28:29 +01:00 · b24cbc68ba
parent 976fdd76c1
commit b24cbc68ba
2 changed files with 2 additions and 1 deletions
--- a/1
+++ b/1
@ -1,5 +1,6 @@
 ver 0.19.14 (not yet released)
 * decoder
+  - dsdiff: fix off-by-one buffer overflow
  - opus: limit tag size to 64 kB
 * fix build failures on non-glibc builds due to constexpr Mutex

--- a/src/decoder/plugins/DsdiffDecoderPlugin.cxx
+++ b/src/decoder/plugins/DsdiffDecoderPlugin.cxx
@ -205,7 +205,7 @@ dsdiff_handle_native_tag(InputStream &is,
 	if (length == 0 || length > 60)
 		return;

-	char string[length];
+	char string[length + 1];
 	char *label;
 	label = string;