decoder/opus: limit tag size to 64 kB

2016-03-06 23:26:48 +01:00 · 2016-03-06 23:26:48 +01:00 · 976fdd76c1
parent bbda335e02
commit 976fdd76c1
2 changed files with 3 additions and 1 deletions
--- a/2
+++ b/2
@ -1,4 +1,6 @@
 ver 0.19.14 (not yet released)
+* decoder
+  - opus: limit tag size to 64 kB
 * fix build failures on non-glibc builds due to constexpr Mutex

 ver 0.19.13 (2016/02/23)
--- a/src/decoder/plugins/OpusReader.hxx
+++ b/src/decoder/plugins/OpusReader.hxx
@ -85,7 +85,7 @@ public:

 	char *ReadString() {
 		uint32_t length;
-		if (!ReadWord(length))
+		if (!ReadWord(length) || length >= 65536)
 			return nullptr;

 		const char *src = (const char *)Read(length);