oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

input/tidal: pass std::string by value 

Don't keep any references to the owner, as the handler method may
delete the owner.
This commit is contained in:
Max Kellermann 2018-01-20 00:33:01 +01:00
parent c3b8568560
commit ab9d9541a8
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/input/plugins/TidalInputPlugin.cxx
View File

@ -74,7 +74,7 @@ private:
void OnTidalSession() noexcept override;
/* virtual methods from TidalTrackHandler */
void OnTidalTrackSuccess(std::string &&url) noexcept override;
void OnTidalTrackSuccess(std::string url) noexcept override;
void OnTidalTrackError(std::exception_ptr error) noexcept override;
};
@ -98,7 +98,7 @@ TidalInputStream::OnTidalSession() noexcept
}
void
TidalInputStream::OnTidalTrackSuccess(std::string &&url) noexcept
TidalInputStream::OnTidalTrackSuccess(std::string url) noexcept
{
const std::lock_guard<Mutex> protect(mutex);

2
src/input/plugins/TidalLoginRequest.hxx
View File

@ -38,7 +38,7 @@ class CurlRequest;
*/
class TidalLoginHandler {
public:
virtual void OnTidalLoginSuccess(std::string &&session) noexcept = 0;
virtual void OnTidalLoginSuccess(std::string session) noexcept = 0;
virtual void OnTidalLoginError(std::exception_ptr error) noexcept = 0;
};

2
src/input/plugins/TidalSessionManager.cxx
View File

@ -70,7 +70,7 @@ TidalSessionManager::AddLoginHandler(TidalSessionHandler &h) noexcept
}
void
TidalSessionManager::OnTidalLoginSuccess(std::string &&_session) noexcept
TidalSessionManager::OnTidalLoginSuccess(std::string _session) noexcept
{
{
const std::lock_guard<Mutex> protect(mutex);

2
src/input/plugins/TidalSessionManager.hxx
View File

@ -158,7 +158,7 @@ private:
}
/* virtual methods from TidalLoginHandler */
void OnTidalLoginSuccess(std::string &&session) noexcept override;
void OnTidalLoginSuccess(std::string session) noexcept override;
void OnTidalLoginError(std::exception_ptr error) noexcept override;
};

2
src/input/plugins/TidalTrackRequest.hxx
View File

@ -40,7 +40,7 @@ class TidalTrackHandler
: public boost::intrusive::list_base_hook<boost::intrusive::link_mode<boost::intrusive::safe_link>>
{
public:
virtual void OnTidalTrackSuccess(std::string &&url) noexcept = 0;
virtual void OnTidalTrackSuccess(std::string url) noexcept = 0;
virtual void OnTidalTrackError(std::exception_ptr error) noexcept = 0;
};