Revert "meson.build: disable -Wsuggest-override with GCC 8"

This reverts commit 56c0733b42.  GCC 8
is no longer supported.
This commit is contained in:
Max Kellermann
2025-01-29 12:22:11 +01:00
parent 3cc7b7dbf9
commit 8ea3f86f43

View File

@@ -167,6 +167,7 @@ test_cxxflags = test_common_flags + [
'-Wmismatched-tags', '-Wmismatched-tags',
'-Woverloaded-virtual', '-Woverloaded-virtual',
'-Wsign-promo', '-Wsign-promo',
'-Wsuggest-override',
'-Wvolatile', '-Wvolatile',
'-Wvirtual-inheritance', '-Wvirtual-inheritance',
@@ -179,12 +180,6 @@ test_cxxflags = test_common_flags + [
'-Winconsistent-missing-destructor-override', '-Winconsistent-missing-destructor-override',
] ]
if compiler.get_id() != 'gcc' or compiler.version().version_compare('>=9')
# The GCC 8 implementation of this flag is buggy: it complains even
# if "final" is present, which implies "override".
test_cxxflags += '-Wsuggest-override'
endif
test_cflags = test_common_flags + [ test_cflags = test_common_flags + [
'-Wmissing-prototypes', '-Wmissing-prototypes',
'-Wstrict-prototypes', '-Wstrict-prototypes',