From 8ea3f86f4320121874d680fc3572c4ad62995afe Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 29 Jan 2025 12:22:11 +0100 Subject: [PATCH] Revert "meson.build: disable -Wsuggest-override with GCC 8" This reverts commit 56c0733b427b444beebb9e1a85d5082a20e2a72b. GCC 8 is no longer supported. --- meson.build | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/meson.build b/meson.build index e9025489c..c71cb3354 100644 --- a/meson.build +++ b/meson.build @@ -167,6 +167,7 @@ test_cxxflags = test_common_flags + [ '-Wmismatched-tags', '-Woverloaded-virtual', '-Wsign-promo', + '-Wsuggest-override', '-Wvolatile', '-Wvirtual-inheritance', @@ -179,12 +180,6 @@ test_cxxflags = test_common_flags + [ '-Winconsistent-missing-destructor-override', ] -if compiler.get_id() != 'gcc' or compiler.version().version_compare('>=9') - # The GCC 8 implementation of this flag is buggy: it complains even - # if "final" is present, which implies "override". - test_cxxflags += '-Wsuggest-override' -endif - test_cflags = test_common_flags + [ '-Wmissing-prototypes', '-Wstrict-prototypes',