oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

decoder/Thread: skip the ReplayGain loader if the feature is disabled

Browse Source 
https://bugs.musicpd.org/view.php?id=4595
This commit is contained in:
Max Kellermann 2016-11-25 13:26:40 +01:00
parent ee57c3490a
commit 86e8b8c10d
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/decoder/DecoderThread.cxx
View File

@ -256,6 +256,23 @@ LoadReplayGain(DecoderClient &client, InputStream &is)
client.SubmitReplayGain(&info); client.SubmitReplayGain(&info);
} }
/**
* Call LoadReplayGain() unless ReplayGain is disabled. This saves
* the I/O overhead when the user is not interested in the feature.
*/
static void
MaybeLoadReplayGain(DecoderBridge &bridge, InputStream &is)
{
{
const ScopeLock protect(bridge.dc.mutex);
if (bridge.dc.replay_gain_mode == ReplayGainMode::OFF)
/* ReplayGain is disabled */
return;
}
LoadReplayGain(bridge, is);
}
/** /**
* Try decoding a stream. * Try decoding a stream.
* *
@ -269,7 +286,7 @@ decoder_run_stream(DecoderBridge &bridge, const char *uri)
auto input_stream = decoder_input_stream_open(dc, uri); auto input_stream = decoder_input_stream_open(dc, uri);
assert(input_stream); assert(input_stream);
LoadReplayGain(bridge, *input_stream); MaybeLoadReplayGain(bridge, *input_stream);
const ScopeLock protect(dc.mutex); const ScopeLock protect(dc.mutex);
@ -376,7 +393,7 @@ decoder_run_file(DecoderBridge &bridge, const char *uri_utf8, Path path_fs)
assert(input_stream); assert(input_stream);
LoadReplayGain(bridge, *input_stream); MaybeLoadReplayGain(bridge, *input_stream);
auto &is = *input_stream; auto &is = *input_stream;
return decoder_plugins_try([&bridge, path_fs, suffix, return decoder_plugins_try([&bridge, path_fs, suffix,