oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command/QueueCommands: disallow moving the current song relative to itself

Browse Source 
This was a no-op previously, but this operation makes no sense.
This commit is contained in:
Max Kellermann 2021-10-07 22:55:29 +02:00
parent c0bcfe244c
commit 78e49928b6
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/command/QueueCommands.cxx
View File

@ -378,8 +378,7 @@ ParseMoveDestination(const char *s, const RangeArg range,
unsigned current = RequireCurrentPosition(p);
assert(current < queue_length);
if (range.Contains(current))
/* no-op */
return range.start;
throw ProtocolError(ACK_ERROR_ARG, "Cannot move current song relative to itself");
if (current >= range.end)
current -= range.Count();
@ -393,8 +392,7 @@ ParseMoveDestination(const char *s, const RangeArg range,
unsigned current = RequireCurrentPosition(p);
assert(current < queue_length);
if (range.Contains(current))
/* no-op */
return range.start;
throw ProtocolError(ACK_ERROR_ARG, "Cannot move current song relative to itself");
if (current >= range.end)
current -= range.Count();