oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

command: don't clobber next list value when preparsing

Browse Source 
This only breaks "update" under list command mode and
no other commands.  This can be done more optimally
without the extra heap allocation via xstrdup(); but is
uncommon enough to not matter.
This commit is contained in:
Eric Wong 2008-09-29 13:18:35 +02:00 committed by Max Kellermann
parent 11245dc119
commit 5f0ed72c48
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/command.c
View File

@ -1422,16 +1422,19 @@ static CommandEntry *getCommandEntryAndCheckArgcAndPermission(struct client *cli
static CommandEntry *getCommandEntryFromString(char *string, int permission)
{
CommandEntry *cmd;
CommandEntry *cmd = NULL;
char *argv[COMMAND_ARGV_MAX] = { NULL };
int argc = buffer2array(string, argv, COMMAND_ARGV_MAX);
char *duplicated = xstrdup(string);
int argc = buffer2array(duplicated, argv, COMMAND_ARGV_MAX);
if (0 == argc)
return NULL;
goto out;
cmd = getCommandEntryAndCheckArgcAndPermission(0, permission,
argc, argv);
out:
free(duplicated);
return cmd;
}