oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

TagAny: invoke ScanGenericTags() on remote files 

This fixes reading ID3 tags on remote files with the commands
"readcomments" and "readpicture".

Closes https://github.com/MusicPlayerDaemon/MPD/issues/1180
This commit is contained in:
Max Kellermann 2021-06-23 20:46:50 +02:00
parent 8be0bcbdb9
commit 5019bdcd52
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -1,6 +1,8 @@
ver 0.22.9 (not yet released) ver 0.22.9 (not yet released)
* database * database
- simple: load all .mpdignore files of all parent directories - simple: load all .mpdignore files of all parent directories
* tags
- fix "readcomments" and "readpicture" on remote files with ID3 tags
* decoder * decoder
- ffmpeg: support the tags "sort_album", "album-sort", "artist-sort" - ffmpeg: support the tags "sort_album", "album-sort", "artist-sort"
- ffmpeg: fix build failure with FFmpeg 3.4 - ffmpeg: fix build failure with FFmpeg 3.4

8
src/TagAny.cxx
View File

@ -25,6 +25,7 @@
#include "client/Client.hxx" #include "client/Client.hxx"
#include "protocol/Ack.hxx" #include "protocol/Ack.hxx"
#include "fs/AllocatedPath.hxx" #include "fs/AllocatedPath.hxx"
#include "input/InputStream.hxx"
#include "util/Compiler.h" #include "util/Compiler.h"
#include "util/UriExtract.hxx" #include "util/UriExtract.hxx"
#include "LocateUri.hxx" #include "LocateUri.hxx"
@ -32,8 +33,13 @@
static void static void
TagScanStream(const char *uri, TagHandler &handler) TagScanStream(const char *uri, TagHandler &handler)
{ {
if (!tag_stream_scan(uri, handler)) Mutex mutex;
auto is = InputStream::OpenReady(uri, mutex);
if (!tag_stream_scan(*is, handler))
throw ProtocolError(ACK_ERROR_NO_EXIST, "Failed to load file"); throw ProtocolError(ACK_ERROR_NO_EXIST, "Failed to load file");
ScanGenericTags(*is, handler);
} }
static void static void