TagAny: invoke ScanGenericTags() on remote files
This fixes reading ID3 tags on remote files with the commands "readcomments" and "readpicture". Closes https://github.com/MusicPlayerDaemon/MPD/issues/1180
This commit is contained in:
		
							
								
								
									
										2
									
								
								NEWS
									
									
									
									
									
								
							
							
						
						
									
										2
									
								
								NEWS
									
									
									
									
									
								
							| @@ -1,6 +1,8 @@ | ||||
| ver 0.22.9 (not yet released) | ||||
| * database | ||||
|   - simple: load all .mpdignore files of all parent directories | ||||
| * tags | ||||
|   - fix "readcomments" and "readpicture" on remote files with ID3 tags | ||||
| * decoder | ||||
|   - ffmpeg: support the tags "sort_album", "album-sort", "artist-sort" | ||||
|   - ffmpeg: fix build failure with FFmpeg 3.4 | ||||
|   | ||||
| @@ -25,6 +25,7 @@ | ||||
| #include "client/Client.hxx" | ||||
| #include "protocol/Ack.hxx" | ||||
| #include "fs/AllocatedPath.hxx" | ||||
| #include "input/InputStream.hxx" | ||||
| #include "util/Compiler.h" | ||||
| #include "util/UriExtract.hxx" | ||||
| #include "LocateUri.hxx" | ||||
| @@ -32,8 +33,13 @@ | ||||
| static void | ||||
| TagScanStream(const char *uri, TagHandler &handler) | ||||
| { | ||||
| 	if (!tag_stream_scan(uri, handler)) | ||||
| 	Mutex mutex; | ||||
|  | ||||
| 	auto is = InputStream::OpenReady(uri, mutex); | ||||
| 	if (!tag_stream_scan(*is, handler)) | ||||
| 		throw ProtocolError(ACK_ERROR_NO_EXIST, "Failed to load file"); | ||||
|  | ||||
| 	ScanGenericTags(*is, handler); | ||||
| } | ||||
|  | ||||
| static void | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Max Kellermann
					Max Kellermann