player_control: don't emit IDLE_PLAYER before audio format is known

Eliminates one IDLE_PLAYER call in playlist_control, and add two new
ones to player_thread.  Fixes Mantis bug 3636.
This commit is contained in:
Max Kellermann 2013-04-08 21:22:06 +02:00
parent a30eb194d5
commit 436335e9a3
3 changed files with 5 additions and 2 deletions

1
NEWS
View File

@ -1,6 +1,7 @@
ver 0.17.4 (2013/??/??)
* protocol:
- allow to omit END in ranges (START:END)
- don't emit IDLE_PLAYER before audio format is known
* decoder:
- ffmpeg: support float planar audio (ffmpeg 1.1)
- ffmpeg: fix AVFrame allocation

View File

@ -127,8 +127,6 @@ pc_play(struct player_control *pc, struct song *song)
assert(pc->next_song == NULL);
player_unlock(pc);
idle_add(IDLE_PLAYER);
}
void

View File

@ -313,6 +313,8 @@ player_open_output(struct player *player)
pc->state = PLAYER_STATE_PLAY;
player_unlock(pc);
idle_add(IDLE_PLAYER);
return true;
} else {
player->output_open = false;
@ -375,6 +377,8 @@ player_check_decoder_startup(struct player *player)
pc->audio_format = dc->in_audio_format;
player_unlock(pc);
idle_add(IDLE_PLAYER);
player->play_audio_format = dc->out_audio_format;
player->decoder_starting = false;