oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

util/HugeAllocator: fix division by zero due to inverted check

Browse Source 
There were two ways this could fail:

1. division by zero when sysconf(_SC_PAGESIZE)==0

2. mmap() failure because the size parameter is not aligned to page
   size

Neither ever happened: sysconf() never fails, and the only caller
passes a size that is already aligned.  Phew.
This commit is contained in:
Max Kellermann 2016-03-06 23:53:41 +01:00
parent 1532ffe215
commit 13f9f0315f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/util/HugeAllocator.cxx
View File

@ -46,7 +46,7 @@ static size_t
AlignToPageSize(size_t size)
{
static const long page_size = sysconf(_SC_PAGESIZE);
if (page_size > 0)
if (page_size == 0)
return size;
size_t ps(page_size);