2004-02-24 00:41:20 +01:00
|
|
|
/* the Music Player Daemon (MPD)
|
2007-04-05 05:22:33 +02:00
|
|
|
* Copyright (C) 2003-2007 by Warren Dukes (warren.dukes@gmail.com)
|
2004-02-24 00:41:20 +01:00
|
|
|
* This project's homepage is: http://www.musicpd.org
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
2008-10-31 09:19:53 +01:00
|
|
|
#ifndef MPD_TAG_H
|
|
|
|
#define MPD_TAG_H
|
2004-02-24 00:41:20 +01:00
|
|
|
|
tag: added a pool for tag items
The new source tag_pool.c manages a pool of reference counted tag_item
objects. This is used to merge tag items of the same type and value,
saving lots of memory. Formerly, only the value itself was pooled,
wasting memory for all the pointers and tag_item structs.
The following results were measured with massif. Started MPD on
amd64, typed "mpc", no song being played. My music database contains
35k tagged songs. The results are what massif reports as "peak".
0.13.2: total 14,131,392; useful 11,408,972; extra 2,722,420
eric: total 18,370,696; useful 15,648,182; extra 2,722,514
mk f34f694: total 15,833,952; useful 13,111,470; extra 2,722,482
mk now: total 12,837,632; useful 10,626,383; extra 2,211,249
This patch set saves 20% memory, and does a good job in reducing heap
fragmentation.
2008-08-29 09:38:37 +02:00
|
|
|
#include "gcc.h"
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-10-08 10:49:29 +02:00
|
|
|
#include <stdint.h>
|
|
|
|
#include <stddef.h>
|
2008-11-03 18:24:00 +01:00
|
|
|
#include <stdbool.h>
|
2008-10-08 10:49:29 +02:00
|
|
|
#include <string.h>
|
|
|
|
|
2008-08-26 08:27:09 +02:00
|
|
|
enum tag_type {
|
|
|
|
TAG_ITEM_ARTIST,
|
|
|
|
TAG_ITEM_ALBUM,
|
2009-01-13 23:43:20 +01:00
|
|
|
TAG_ITEM_ALBUM_ARTIST,
|
2008-08-26 08:27:09 +02:00
|
|
|
TAG_ITEM_TITLE,
|
|
|
|
TAG_ITEM_TRACK,
|
|
|
|
TAG_ITEM_NAME,
|
|
|
|
TAG_ITEM_GENRE,
|
|
|
|
TAG_ITEM_DATE,
|
|
|
|
TAG_ITEM_COMPOSER,
|
|
|
|
TAG_ITEM_PERFORMER,
|
|
|
|
TAG_ITEM_COMMENT,
|
|
|
|
TAG_ITEM_DISC,
|
|
|
|
TAG_NUM_OF_ITEM_TYPES
|
|
|
|
};
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-02-05 11:17:33 +01:00
|
|
|
extern const char *mpdTagItemKeys[];
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 09:38:11 +02:00
|
|
|
struct tag_item {
|
2008-08-26 08:27:09 +02:00
|
|
|
enum tag_type type;
|
2008-10-13 09:40:14 +02:00
|
|
|
char value[sizeof(long)];
|
tag: added a pool for tag items
The new source tag_pool.c manages a pool of reference counted tag_item
objects. This is used to merge tag items of the same type and value,
saving lots of memory. Formerly, only the value itself was pooled,
wasting memory for all the pointers and tag_item structs.
The following results were measured with massif. Started MPD on
amd64, typed "mpc", no song being played. My music database contains
35k tagged songs. The results are what massif reports as "peak".
0.13.2: total 14,131,392; useful 11,408,972; extra 2,722,420
eric: total 18,370,696; useful 15,648,182; extra 2,722,514
mk f34f694: total 15,833,952; useful 13,111,470; extra 2,722,482
mk now: total 12,837,632; useful 10,626,383; extra 2,211,249
This patch set saves 20% memory, and does a good job in reducing heap
fragmentation.
2008-08-29 09:38:37 +02:00
|
|
|
} mpd_packed;
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 09:38:11 +02:00
|
|
|
struct tag {
|
2004-03-11 01:16:49 +01:00
|
|
|
int time;
|
2008-08-29 09:38:29 +02:00
|
|
|
struct tag_item **items;
|
2008-09-29 13:29:33 +02:00
|
|
|
uint8_t numOfItems;
|
2008-08-29 09:38:11 +02:00
|
|
|
};
|
2004-02-24 00:41:20 +01:00
|
|
|
|
2008-08-29 14:48:39 +02:00
|
|
|
struct tag *tag_ape_load(const char *file);
|
2005-03-07 01:51:21 +01:00
|
|
|
|
2008-08-29 09:38:21 +02:00
|
|
|
struct tag *tag_new(void);
|
2004-02-24 00:41:20 +01:00
|
|
|
|
2008-08-29 09:38:21 +02:00
|
|
|
void tag_lib_init(void);
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 09:38:21 +02:00
|
|
|
void tag_clear_items_by_type(struct tag *tag, enum tag_type itemType);
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 09:38:21 +02:00
|
|
|
void tag_free(struct tag *tag);
|
2004-02-24 00:41:20 +01:00
|
|
|
|
tag: try not to reallocate tag.items in every add() call
If many tag_items are added at once while the tag cache is being
loaded, manage these items in a static fixed list, instead of
reallocating the list with every newly created item. This reduces
heap fragmentation.
Massif results again:
mk before: total 12,837,632; useful 10,626,383; extra 2,211,249
mk now: total 12,736,720; useful 10,626,383; extra 2,110,337
The "useful" value is the same since this patch only changes the way
we allocate the same amount of memory, but heap fragmentation was
reduced by 5%.
2008-08-29 09:39:08 +02:00
|
|
|
/**
|
|
|
|
* Gives an optional hint to the tag library that we will now add
|
|
|
|
* several tag items; this is used by the library to optimize memory
|
|
|
|
* allocation. Only one tag may be in this state, and this tag must
|
|
|
|
* not have any items yet. You must call tag_end_add() when you are
|
|
|
|
* done.
|
|
|
|
*/
|
|
|
|
void tag_begin_add(struct tag *tag);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Finishes the operation started with tag_begin_add().
|
|
|
|
*/
|
|
|
|
void tag_end_add(struct tag *tag);
|
|
|
|
|
2008-08-29 09:38:21 +02:00
|
|
|
void tag_add_item_n(struct tag *tag, enum tag_type itemType,
|
tag: try not to reallocate tag.items in every add() call
If many tag_items are added at once while the tag cache is being
loaded, manage these items in a static fixed list, instead of
reallocating the list with every newly created item. This reduces
heap fragmentation.
Massif results again:
mk before: total 12,837,632; useful 10,626,383; extra 2,211,249
mk now: total 12,736,720; useful 10,626,383; extra 2,110,337
The "useful" value is the same since this patch only changes the way
we allocate the same amount of memory, but heap fragmentation was
reduced by 5%.
2008-08-29 09:39:08 +02:00
|
|
|
const char *value, size_t len);
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 09:38:24 +02:00
|
|
|
static inline void tag_add_item(struct tag *tag, enum tag_type itemType,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
tag_add_item_n(tag, itemType, value, strlen(value));
|
|
|
|
}
|
2004-11-10 22:58:27 +01:00
|
|
|
|
2008-08-29 14:48:39 +02:00
|
|
|
struct tag *tag_dup(const struct tag *tag);
|
2004-02-24 00:41:20 +01:00
|
|
|
|
2009-01-03 23:28:51 +01:00
|
|
|
/**
|
|
|
|
* Merges the data from two tags. If both tags share data for the
|
|
|
|
* same tag_type, only data from "add" is used.
|
|
|
|
*
|
|
|
|
* @return a newly allocated tag, which must be freed with tag_free()
|
|
|
|
*/
|
|
|
|
struct tag *
|
|
|
|
tag_merge(const struct tag *base, const struct tag *add);
|
|
|
|
|
2008-11-04 16:55:11 +01:00
|
|
|
/**
|
|
|
|
* Returns true if the tag contains no items. This ignores the "time"
|
|
|
|
* attribute.
|
|
|
|
*/
|
|
|
|
static inline bool
|
|
|
|
tag_is_empty(const struct tag *tag)
|
|
|
|
{
|
|
|
|
return tag->numOfItems == 0;
|
|
|
|
}
|
|
|
|
|
2009-01-15 00:21:08 +01:00
|
|
|
/**
|
|
|
|
* Returns the first value of the specified tag type, or NULL if none
|
|
|
|
* is present in this tag object.
|
|
|
|
*/
|
|
|
|
const char *
|
|
|
|
tag_get_value(const struct tag *tag, enum tag_type type);
|
|
|
|
|
2008-11-03 18:24:00 +01:00
|
|
|
/**
|
|
|
|
* Checks whether the tag contains one or more items with
|
|
|
|
* the specified type.
|
|
|
|
*/
|
|
|
|
bool tag_has_type(const struct tag *tag, enum tag_type type);
|
|
|
|
|
2008-08-29 14:48:39 +02:00
|
|
|
int tag_equal(const struct tag *tag1, const struct tag *tag2);
|
2004-06-01 12:28:06 +02:00
|
|
|
|
2004-02-24 00:41:20 +01:00
|
|
|
#endif
|