
This is the second of two commits in a series that must be picked together. This series of two commits moves parts of lib/krb5/ infrastructure functionality to lib/base/, leaving behind wrappers. Some parts of libkrb5 are entirely generic or easily made so, and could be useful in various parts of Heimdal that are not specific to the krb5 API, such as: - lib/gssapi/ (especially since the integration of NegoEx) - lib/hx509/ - bx509d (which should really move out of kdc/) For the above we need to move these bits of lib/krb5/: - lib/krb5/config_file.c (all of it, leaving forwardings behind) - lib/krb5/config_reg.c (all of it) - lib/krb5/plugin.c (all of it, leaving forwardings behind) - lib/krb5/log.c (all of it, ditto) - lib/krb5/heim_err.et (all of it) And because of those two, these too must also move: - lib/krb5/expand_path.c (all of it, leaving forwardings behind) - lib/krb5/warn.c (just the warning functions, ditto) The changes to the moved files are mostly quite straightforward and are best reviewed with --word-diff=color. We're also creating a heim_context and a heim API to go with it. But it's as thin as possible, with as little state as necessary to enable this move. Functions for dealing with error messages use callbacks. Moving plugin.c does have one knock-on effect on all users of the old krb5 plugin API (which remains), which is that a global search and replace of struct krb5_plugin_data to struct heim_plugin_data was needed, though the layout and size of that structure doesn't change, so the ABI doesn't either. As well, we now build lib/vers/ and lib/com_err/ before lib/base/ so as to be able to move lib/krb5/heim_err.et to lib/base/ so that we can make use of HEIM_ERR_* in lib/base/, specifically in the files that moved. Once this is all done we'll be able to use config files and plugins in lib/hx509/, we'll be able to move bx509d out of kdc/, and so on. Most if not all of the new functions in lib/base/ are Heimdal-private, thus calling conventions for them are not declared. Status: - builds and passes CIs (Travis, Appveyor) - ran make check-valgrind and no new leaks or other memory errors - ready for review HOW TO REVIEW: $ # Review file moves: $ git log --stat -n1 HEAD^ $ $ # Review changes to moved files using --word-diff=color $ git log -p -b -w --word-diff=color HEAD^..HEAD \ lib/base/config_file.c \ lib/base/config_reg.c \ lib/base/expand_path.c \ lib/base/warn.c \ lib/krb5/config_file.c \ lib/krb5/config_reg.c \ lib/krb5/expand_path.c \ lib/krb5/warn.c $ $ # Review the whole thing, possibly adding -b and/or -w, and $ # maybe --word-diff=color: $ git log -p origin/master..HEAD $ git log -p -b -w origin/master..HEAD $ git log -p -b -w --word-diff=color origin/master..HEAD TBD (future commits): - make lib/gssapi use the new heimbase functions - move kx509/bx509d common code to lib/hx509/ or other approp. location - move bx509d out of kdc/
123 lines
4.3 KiB
C
123 lines
4.3 KiB
C
/*
|
|
* Copyright (c) 2019 Kungliga Tekniska Högskolan
|
|
* (Royal Institute of Technology, Stockholm, Sweden).
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* 3. Neither the name of the Institute nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE INSTITUTE AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE INSTITUTE OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "kdc_locl.h"
|
|
#include "token_validator_plugin.h"
|
|
|
|
struct plctx {
|
|
const char *realm;
|
|
const char *token_kind;
|
|
krb5_data *token;
|
|
const char * const *audiences;
|
|
size_t naudiences;
|
|
krb5_boolean result;
|
|
krb5_principal actual_principal;
|
|
krb5_times token_times;
|
|
};
|
|
|
|
static krb5_error_code KRB5_LIB_CALL
|
|
plcallback(krb5_context context, const void *plug, void *plugctx, void *userctx)
|
|
{
|
|
const krb5plugin_token_validator_ftable *validator = plug;
|
|
krb5_error_code ret;
|
|
struct plctx *plctx = userctx;
|
|
|
|
ret = validator->validate(plugctx, context, plctx->realm,
|
|
plctx->token_kind, plctx->token,
|
|
plctx->audiences, plctx->naudiences,
|
|
&plctx->result, &plctx->actual_principal,
|
|
&plctx->token_times);
|
|
if (ret) {
|
|
krb5_free_principal(context, plctx->actual_principal);
|
|
plctx->actual_principal = NULL;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static const char *plugin_deps[] = { "krb5", NULL };
|
|
|
|
static struct heim_plugin_data token_validator_data = {
|
|
"kdc",
|
|
KDC_PLUGIN_BEARER,
|
|
1,
|
|
plugin_deps,
|
|
krb5_get_instance
|
|
};
|
|
|
|
/*
|
|
* Invoke a plugin to validate a JWT/SAML/OIDC token and partially-evaluate
|
|
* access control.
|
|
*/
|
|
krb5_error_code
|
|
kdc_validate_token(krb5_context context,
|
|
const char *realm,
|
|
const char *token_kind,
|
|
krb5_data *token,
|
|
const char * const *audiences,
|
|
size_t naudiences,
|
|
krb5_principal *actual_principal,
|
|
krb5_times *token_times)
|
|
{
|
|
krb5_error_code ret;
|
|
struct plctx ctx;
|
|
|
|
memset(&ctx, 0, sizeof(ctx));
|
|
ctx.realm = realm;
|
|
ctx.token_kind = token_kind;
|
|
ctx.token = token;
|
|
ctx.audiences = audiences;
|
|
ctx.naudiences = naudiences;
|
|
ctx.result = FALSE;
|
|
ctx.actual_principal = NULL;
|
|
|
|
krb5_clear_error_message(context);
|
|
ret = _krb5_plugin_run_f(context, &token_validator_data, 0, &ctx,
|
|
plcallback);
|
|
if (ret == 0 && ctx.result && actual_principal) {
|
|
*actual_principal = ctx.actual_principal;
|
|
ctx.actual_principal = NULL;
|
|
}
|
|
|
|
if (token_times)
|
|
*token_times = ctx.token_times;
|
|
|
|
krb5_free_principal(context, ctx.actual_principal);
|
|
if (ret)
|
|
krb5_prepend_error_message(context, ret, "bearer token validation "
|
|
"failed: ");
|
|
else if (!ctx.result)
|
|
krb5_set_error_message(context, ret = EACCES,
|
|
"bearer token validation failed");
|
|
return ret;
|
|
}
|