5e3c0a7ce0
We're logging SUCCESS even when the KDC sends error replies. That's because we're returning success to process_request() even when we send errors to clients. The error we want to send to the client, and that we succeed or fail to send it, are different statuses. To fix this we'll add a `ret` field to the common service request state structure, HEIM_SVC_REQUEST_DESC_COMMON_ELEMENTS / heim_svc_req_desc_common_s.
75 lines
3.5 KiB
C
75 lines
3.5 KiB
C
/*
|
|
* Copyright (c) 2010 Kungliga Tekniska Högskolan
|
|
* (Royal Institute of Technology, Stockholm, Sweden).
|
|
* All rights reserved.
|
|
*
|
|
* Portions Copyright (c) 2010 Apple Inc. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* 3. Neither the name of the Institute nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE INSTITUTE AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE INSTITUTE OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef HEIMBASE_SVC_H
|
|
#define HEIMBASE_SVC_H 1
|
|
|
|
/*
|
|
* This file is meant to be included in services, which can
|
|
*
|
|
* #define heim_pcontext krb5_context
|
|
*
|
|
* or whatever is appropriate.
|
|
*/
|
|
|
|
#define HEIM_SVC_REQUEST_DESC_COMMON_ELEMENTS \
|
|
/* Input */ \
|
|
heim_pcontext context; \
|
|
heim_pconfig config; \
|
|
heim_context hcontext; \
|
|
heim_log_facility *logf; \
|
|
const char *from; \
|
|
struct sockaddr *addr; \
|
|
int datagram_reply; \
|
|
heim_octet_string request; \
|
|
\
|
|
/* Output */ \
|
|
heim_octet_string *reply; \
|
|
unsigned int use_request_t:1; \
|
|
\
|
|
/* Common state, to be freed in process.c */ \
|
|
struct timeval tv_start; \
|
|
struct timeval tv_end; \
|
|
const char *reqtype; \
|
|
char *cname; \
|
|
char *sname; \
|
|
const char *e_text; \
|
|
char *e_text_buf; \
|
|
heim_string_t reason; \
|
|
heim_array_t kv; \
|
|
int32_t ret
|
|
|
|
#endif /* HEIMBASE_SVC_H */
|