_gss_secure_release_buffer_set() patch changed minor_status to 0, not *minor_status as correct. No behavioural change as _gss_secure_release_buffer_set() would have set it anyway, but obviously this was unintentional.
		
			
				
	
	
		
			91 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			91 lines
		
	
	
		
			2.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2004, PADL Software Pty Ltd.
 | 
						|
 * All rights reserved.
 | 
						|
 *
 | 
						|
 * Redistribution and use in source and binary forms, with or without
 | 
						|
 * modification, are permitted provided that the following conditions
 | 
						|
 * are met:
 | 
						|
 *
 | 
						|
 * 1. Redistributions of source code must retain the above copyright
 | 
						|
 *    notice, this list of conditions and the following disclaimer.
 | 
						|
 *
 | 
						|
 * 2. Redistributions in binary form must reproduce the above copyright
 | 
						|
 *    notice, this list of conditions and the following disclaimer in the
 | 
						|
 *    documentation and/or other materials provided with the distribution.
 | 
						|
 *
 | 
						|
 * 3. Neither the name of PADL Software nor the names of its contributors
 | 
						|
 *    may be used to endorse or promote products derived from this software
 | 
						|
 *    without specific prior written permission.
 | 
						|
 *
 | 
						|
 * THIS SOFTWARE IS PROVIDED BY PADL SOFTWARE AND CONTRIBUTORS ``AS IS'' AND
 | 
						|
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 | 
						|
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 | 
						|
 * ARE DISCLAIMED.  IN NO EVENT SHALL PADL SOFTWARE OR CONTRIBUTORS BE LIABLE
 | 
						|
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 | 
						|
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 | 
						|
 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 | 
						|
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 | 
						|
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 | 
						|
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 | 
						|
 * SUCH DAMAGE.
 | 
						|
 */
 | 
						|
 | 
						|
#include "mech_locl.h"
 | 
						|
 | 
						|
GSSAPI_LIB_FUNCTION OM_uint32 GSSAPI_LIB_CALL
 | 
						|
gss_inquire_cred_by_oid (OM_uint32 *minor_status,
 | 
						|
			 gss_const_cred_id_t cred_handle,
 | 
						|
			 const gss_OID desired_object,
 | 
						|
			 gss_buffer_set_t *data_set)
 | 
						|
{
 | 
						|
	struct _gss_cred *cred = (struct _gss_cred *) cred_handle;
 | 
						|
	OM_uint32		status = GSS_S_COMPLETE;
 | 
						|
	struct _gss_mechanism_cred *mc;
 | 
						|
	gssapi_mech_interface	m;
 | 
						|
	gss_buffer_set_t set = GSS_C_NO_BUFFER_SET;
 | 
						|
 | 
						|
	*minor_status = 0;
 | 
						|
	*data_set = GSS_C_NO_BUFFER_SET;
 | 
						|
 | 
						|
	if (cred == NULL)
 | 
						|
		return GSS_S_NO_CRED;
 | 
						|
 | 
						|
	status = GSS_S_FAILURE;
 | 
						|
 | 
						|
	HEIM_TAILQ_FOREACH(mc, &cred->gc_mc, gmc_link) {
 | 
						|
		gss_buffer_set_t rset = GSS_C_NO_BUFFER_SET;
 | 
						|
		size_t i;
 | 
						|
 | 
						|
		m = mc->gmc_mech;
 | 
						|
		if (m == NULL) {
 | 
						|
			_gss_secure_release_buffer_set(minor_status, &set);
 | 
						|
			*minor_status = 0;
 | 
						|
			return GSS_S_BAD_MECH;
 | 
						|
		}
 | 
						|
 | 
						|
		if (m->gm_inquire_cred_by_oid == NULL)
 | 
						|
			continue;
 | 
						|
 | 
						|
		status = m->gm_inquire_cred_by_oid(minor_status,
 | 
						|
		    mc->gmc_cred, desired_object, &rset);
 | 
						|
		if (status != GSS_S_COMPLETE) {
 | 
						|
			_gss_mg_error(m, *minor_status);
 | 
						|
			continue;
 | 
						|
		}
 | 
						|
 | 
						|
		for (i = 0; rset != NULL && i < rset->count; i++) {
 | 
						|
			status = gss_add_buffer_set_member(minor_status,
 | 
						|
			     &rset->elements[i], &set);
 | 
						|
			if (status != GSS_S_COMPLETE)
 | 
						|
				break;
 | 
						|
		}
 | 
						|
		_gss_secure_release_buffer_set(minor_status, &rset);
 | 
						|
	}
 | 
						|
	if (set == GSS_C_NO_BUFFER_SET && status == GSS_S_COMPLETE)
 | 
						|
		status = GSS_S_FAILURE;
 | 
						|
	*data_set = set;
 | 
						|
	*minor_status = 0;
 | 
						|
	return status;
 | 
						|
}
 | 
						|
 |