Files
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00

470 lines
12 KiB
C

/*
* Copyright (c) 1997 - 2005 Kungliga Tekniska Högskolan
* (Royal Institute of Technology, Stockholm, Sweden).
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* 3. Neither the name of the Institute nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE INSTITUTE AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE INSTITUTE OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include "kafs_locl.h"
#define AUTH_SUPERUSER "afs"
/*
* Here only ASCII characters are relevant.
*/
#define IsAsciiLower(c) ('a' <= (c) && (c) <= 'z')
#define ToAsciiUpper(c) ((c) - 'a' + 'A')
static void (*kafs_verbose)(void *, const char *);
static void *kafs_verbose_ctx;
void
_kafs_foldup(char *a, const char *b)
{
for (; *b; a++, b++)
if (IsAsciiLower(*b))
*a = ToAsciiUpper(*b);
else
*a = *b;
*a = '\0';
}
void
kafs_set_verbose(void (*f)(void *, const char *), void *ctx)
{
if (f) {
kafs_verbose = f;
kafs_verbose_ctx = ctx;
}
}
int
kafs_settoken_rxkad(const char *cell, struct ClearToken *ct,
void *ticket, size_t ticket_len)
{
struct ViceIoctl parms;
char buf[2048], *t;
int32_t sizeof_x;
t = buf;
/*
* length of secret token followed by secret token
*/
sizeof_x = ticket_len;
memcpy(t, &sizeof_x, sizeof(sizeof_x));
t += sizeof(sizeof_x);
memcpy(t, ticket, sizeof_x);
t += sizeof_x;
/*
* length of clear token followed by clear token
*/
sizeof_x = sizeof(*ct);
memcpy(t, &sizeof_x, sizeof(sizeof_x));
t += sizeof(sizeof_x);
memcpy(t, ct, sizeof_x);
t += sizeof_x;
/*
* do *not* mark as primary cell
*/
sizeof_x = 0;
memcpy(t, &sizeof_x, sizeof(sizeof_x));
t += sizeof(sizeof_x);
/*
* follow with cell name
*/
sizeof_x = strlen(cell) + 1;
memcpy(t, cell, sizeof_x);
t += sizeof_x;
/*
* Build argument block
*/
parms.in = buf;
parms.in_size = t - buf;
parms.out = 0;
parms.out_size = 0;
return k_pioctl(0, VIOCSETTOK, &parms, 0);
}
void
_kafs_fixup_viceid(struct ClearToken *ct, uid_t uid)
{
#define ODD(x) ((x) & 1)
/* According to Transarc conventions ViceId is valid iff
* (EndTimestamp - BeginTimestamp) is odd. By decrementing EndTime
* the transformations:
*
* (issue_date, life) -> (StartTime, EndTime) -> (issue_date, life)
* preserves the original values.
*/
if (uid != 0) /* valid ViceId */
{
if (!ODD(ct->EndTimestamp - ct->BeginTimestamp))
ct->EndTimestamp--;
}
else /* not valid ViceId */
{
if (ODD(ct->EndTimestamp - ct->BeginTimestamp))
ct->EndTimestamp--;
}
}
/* Try to get a db-server for an AFS cell from a AFSDB record */
static int
dns_find_cell(const char *cell, char *dbserver, size_t len)
{
struct rk_dns_reply *r;
int ok = -1;
r = rk_dns_lookup(cell, "afsdb");
if(r){
struct rk_resource_record *rr = r->head;
while(rr){
if(rr->type == rk_ns_t_afsdb && rr->u.afsdb->preference == 1){
strlcpy(dbserver,
rr->u.afsdb->domain,
len);
ok = 0;
break;
}
rr = rr->next;
}
rk_dns_free_data(r);
}
return ok;
}
/*
* Try to find the cells we should try to klog to in "file".
*/
static void
find_cells(const char *file, char ***cells, int *idx)
{
FILE *f;
char cell[64];
int i;
int ind = *idx;
f = fopen(file, "r");
if (f == NULL)
return;
while (fgets(cell, sizeof(cell), f)) {
char *t;
t = cell + strlen(cell);
for (; t >= cell; t--)
if (*t == '\n' || *t == '\t' || *t == ' ')
*t = 0;
if (cell[0] == '\0' || cell[0] == '#')
continue;
for(i = 0; i < ind; i++)
if(strcmp((*cells)[i], cell) == 0)
break;
if(i == ind){
char **tmp;
tmp = realloc(*cells, (ind + 1) * sizeof(**cells));
if (tmp == NULL)
break;
*cells = tmp;
(*cells)[ind] = strdup(cell);
if ((*cells)[ind] == NULL)
break;
++ind;
}
}
fclose(f);
*idx = ind;
}
/*
* Get tokens for all cells[]
*/
static int
afslog_cells(struct kafs_data *data, char **cells, int max, uid_t uid,
const char *homedir)
{
int ret = 0;
int i;
for (i = 0; i < max; i++) {
int er = (*data->afslog_uid)(data, cells[i], 0, uid, homedir);
if (er)
ret = er;
}
return ret;
}
int
_kafs_afslog_all_local_cells(struct kafs_data *data,
uid_t uid, const char *homedir)
{
int ret;
char **cells = NULL;
int idx = 0;
if (homedir == NULL)
homedir = getenv("HOME");
if (homedir != NULL) {
char home[MaxPathLen];
snprintf(home, sizeof(home), "%s/.TheseCells", homedir);
find_cells(home, &cells, &idx);
}
find_cells(_PATH_THESECELLS, &cells, &idx);
find_cells(_PATH_THISCELL, &cells, &idx);
find_cells(_PATH_ARLA_THESECELLS, &cells, &idx);
find_cells(_PATH_ARLA_THISCELL, &cells, &idx);
find_cells(_PATH_OPENAFS_DEBIAN_THESECELLS, &cells, &idx);
find_cells(_PATH_OPENAFS_DEBIAN_THISCELL, &cells, &idx);
find_cells(_PATH_OPENAFS_MACOSX_THESECELLS, &cells, &idx);
find_cells(_PATH_OPENAFS_MACOSX_THISCELL, &cells, &idx);
find_cells(_PATH_ARLA_DEBIAN_THESECELLS, &cells, &idx);
find_cells(_PATH_ARLA_DEBIAN_THISCELL, &cells, &idx);
find_cells(_PATH_ARLA_OPENBSD_THESECELLS, &cells, &idx);
find_cells(_PATH_ARLA_OPENBSD_THISCELL, &cells, &idx);
ret = afslog_cells(data, cells, idx, uid, homedir);
while(idx > 0)
free(cells[--idx]);
free(cells);
return ret;
}
static int
file_find_cell(struct kafs_data *data,
const char *cell, char **realm, int exact)
{
FILE *F;
char buf[1024];
char *p;
int ret = -1;
if ((F = fopen(_PATH_CELLSERVDB, "r"))
|| (F = fopen(_PATH_ARLA_CELLSERVDB, "r"))
|| (F = fopen(_PATH_OPENAFS_DEBIAN_CELLSERVDB, "r"))
|| (F = fopen(_PATH_OPENAFS_MACOSX_CELLSERVDB, "r"))
|| (F = fopen(_PATH_ARLA_DEBIAN_CELLSERVDB, "r"))) {
while (fgets(buf, sizeof(buf), F)) {
int cmp;
if (buf[0] != '>')
continue; /* Not a cell name line, try next line */
p = buf;
strsep(&p, " \t\n#");
if (exact)
cmp = strcmp(buf + 1, cell);
else
cmp = strncmp(buf + 1, cell, strlen(cell));
if (cmp == 0) {
/*
* We found the cell name we're looking for.
* Read next line on the form ip-address '#' hostname
*/
if (fgets(buf, sizeof(buf), F) == NULL)
break; /* Read failed, give up */
p = strchr(buf, '#');
if (p == NULL)
break; /* No '#', give up */
p++;
if (buf[strlen(buf) - 1] == '\n')
buf[strlen(buf) - 1] = '\0';
*realm = (*data->get_realm)(data, p);
if (*realm && **realm != '\0')
ret = 0;
break; /* Won't try any more */
}
}
fclose(F);
}
return ret;
}
/* Find the realm associated with cell. Do this by opening CellServDB
file and getting the realm-of-host for the first VL-server for the
cell.
This does not work when the VL-server is living in one realm, but
the cell it is serving is living in another realm.
Return 0 on success, -1 otherwise.
*/
int
_kafs_realm_of_cell(struct kafs_data *data,
const char *cell, char **realm)
{
char buf[1024];
int ret;
ret = file_find_cell(data, cell, realm, 1);
if (ret == 0)
return ret;
if (dns_find_cell(cell, buf, sizeof(buf)) == 0) {
*realm = (*data->get_realm)(data, buf);
if(*realm != NULL)
return 0;
}
return file_find_cell(data, cell, realm, 0);
}
static int
_kafs_try_get_cred(struct kafs_data *data, const char *user, const char *cell,
const char *realm, uid_t uid, struct kafs_token *kt)
{
int ret;
ret = (*data->get_cred)(data, user, cell, realm, uid, kt);
if (kafs_verbose) {
const char *estr = (*data->get_error)(data, ret);
char *str;
int aret;
aret = asprintf(&str, "%s tried afs%s%s@%s -> %s (%d)",
data->name, cell ? "/" : "",
cell ? cell : "", realm, estr ? estr : "unknown", ret);
if (aret != -1) {
(*kafs_verbose)(kafs_verbose_ctx, str);
free(str);
} else {
(*kafs_verbose)(kafs_verbose_ctx, "out of memory");
}
if (estr)
(*data->free_error)(data, estr);
}
return ret;
}
int
_kafs_get_cred(struct kafs_data *data,
const char *cell,
const char *realm_hint,
const char *realm,
uid_t uid,
struct kafs_token *kt)
{
int ret = -1;
char *vl_realm;
char CELL[64];
/* We're about to find the realm that holds the key for afs in
* the specified cell. The problem is that null-instance
* afs-principals are common and that hitting the wrong realm might
* yield the wrong afs key. The following assumptions were made.
*
* Any realm passed to us is preferred.
*
* If there is a realm with the same name as the cell, it is most
* likely the correct realm to talk to.
*
* In most (maybe even all) cases the database servers of the cell
* will live in the realm we are looking for.
*
* Try the local realm, but if the previous cases fail, this is
* really a long shot.
*
*/
/* comments on the ordering of these tests */
/* If the user passes a realm, she probably knows something we don't
* know and we should try afs@realm_hint.
*/
if (realm_hint) {
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
cell, realm_hint, uid, kt);
if (ret == 0) return 0;
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
NULL, realm_hint, uid, kt);
if (ret == 0) return 0;
}
_kafs_foldup(CELL, cell);
/*
* If the AFS servers have a file /usr/afs/etc/krb.conf containing
* REALM we still don't have to resort to cross-cell authentication.
* Try afs.cell@REALM.
*/
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
cell, realm, uid, kt);
if (ret == 0) return 0;
/*
* If cell == realm we don't need no cross-cell authentication.
* Try afs@REALM.
*/
if (strcmp(CELL, realm) == 0) {
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
NULL, realm, uid, kt);
if (ret == 0) return 0;
}
/*
* We failed to get ``first class tickets'' for afs,
* fall back to cross-cell authentication.
* Try afs@CELL.
* Try afs.cell@CELL.
*/
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
NULL, CELL, uid, kt);
if (ret == 0) return 0;
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
cell, CELL, uid, kt);
if (ret == 0) return 0;
/*
* Perhaps the cell doesn't correspond to any realm?
* Use realm of first volume location DB server.
* Try afs.cell@VL_REALM.
* Try afs@VL_REALM???
*/
if (_kafs_realm_of_cell(data, cell, &vl_realm) == 0
&& strcmp(vl_realm, realm) != 0
&& strcmp(vl_realm, CELL) != 0) {
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
cell, vl_realm, uid, kt);
if (ret)
ret = _kafs_try_get_cred(data, AUTH_SUPERUSER,
NULL, vl_realm, uid, kt);
free(vl_realm);
if (ret == 0) return 0;
}
return ret;
}