Commit Graph

18 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hörnquist Åstrand
942a821fab remove RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
fc3c0c2192 add destroy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24437 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:43:55 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
f536c384d8 N_()ify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23785 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:27:21 +00:00
Love Hörnquist Åstrand
3df3ff4856 use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23293 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 03:28:22 +00:00
Love Hörnquist Åstrand
08b361da54 (mkt_remove_entry): realloc can return NULL on success in the case 0
entries are allocated, From Andrew Bartlet


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16352 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-12-05 18:39:46 +00:00
Love Hörnquist Åstrand
b6037cc29a Index by name and start reference counting on entries.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16325 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-12-01 12:40:22 +00:00
Love Hörnquist Åstrand
ed2c4b3694 (mkt_remove_entry): check if there isn't any entries in the keytab
before removing any since that leads to bad pointer arithmetic and
crashing. From: Wynn Wilkes <wwilkes@vintela.com>.
Make the function return KRB5_KT_NOTFOUND if the entry wasn't in the
keytab (just like the filebased keytab).


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15169 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-18 04:44:40 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-05-14 06:14:52 +00:00
Assar Westerlund
b19b0679a1 (mkt_get_name): use strlcpy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7880 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-02-07 03:18:39 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Johan Danielsson
46c33ed736 make krb5_mkt_ops const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7073 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-03 14:45:54 +00:00
Assar Westerlund
e70e38085d new files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6921 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-10 16:22:50 +00:00