oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,266 Commits 2 Branches 2 Tags
f0f07ff408031a76cf892515f5f72a0d5e30fabf
Commit Graph

43 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hornquist Astrand
e1ecb6f7a6 Catch uninited variable [CID-182] 2009-07-30 09:40:05 +02:00
Love Hörnquist Åstrand
942a821fab remove RCSID 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
defb2afef1 parse/store flags field 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24469 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:49:10 +00:00
Love Hörnquist Åstrand
329e5b51b3 set flags and aliases 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24459 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:47:32 +00:00
Love Hörnquist Åstrand
bd479a0820 Add fkt_destroy 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24449 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:45:56 +00:00
Love Hörnquist Åstrand
6536a629f4 add destroy 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24435 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:43:33 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
2f980ebc54 N_()ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23783 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-07 21:26:29 +00:00
Love Hörnquist Åstrand
7b5981996c sprinle O_CLOEXEC, from Andrew Bartlett 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23474 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-28 08:49:43 +00:00
Love Hörnquist Åstrand
c50ae6b63c xfree, close-on-exec 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23469 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-27 12:17:12 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
34344451a6 use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23290 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 03:27:51 +00:00
Love Hörnquist Åstrand
34faa9fe6e better error strings for the keytab fetching functions 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22532 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-27 11:59:18 +00:00
Love Hörnquist Åstrand
ba1492d065 (fkt_next_entry_int): read the 32 bit kvno if the reset of the data is 
longer then 4 bytes in hope to be forward compatible. Pointed out by
Michael B Allen.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17457 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-05-05 12:36:57 +00:00
Love Hörnquist Åstrand
5a761c7f96 (krb5_kt_ret_principal): plug a memory leak 
Coverity NetBSD CID#1890


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17013 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-07 21:57:31 +00:00
Love Hörnquist Åstrand
4b2323bd43 (fkt_next_entry_int): remove a dereferencing NULL pointer, found by 
IBM checker.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16941 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-02 01:22:33 +00:00
Love Hörnquist Åstrand
237641e2ca update (c) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15634 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-07-13 06:08:07 +00:00
Love Hörnquist Åstrand
f1542ef9cd (fkt_start_seq_get_int): check return value from krb5_storage_from_fd 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15632 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-07-13 05:34:29 +00:00
Love Hörnquist Åstrand
897ad7f8f3 Adapt to changed signature of _krb5_xunlock, clear more error string 
where needed.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15326 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-31 21:50:43 +00:00
Love Hörnquist Åstrand
1ed2143174 (fkt_remove_entry): need to call krb5_kt_free_entry after each 
fkt_next_entry_int. From: Wynn Wilkes <wwilkes@vintela.com>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15176 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-19 04:11:34 +00:00
Love Hörnquist Åstrand
f9ca795602 Add new keytab file format JAVA14 that doesn't the use extended kvnos, 
as hinted, this is needed for Java's Kerberos implementation.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15147 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-16 21:13:42 +00:00
Love Hörnquist Åstrand
b5f0883c6a add krb5_wrfkt_ops/WRFILE (same as FILE) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13293 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-01-25 21:03:22 +00:00
Love Hörnquist Åstrand
11dce94342 do locking, found to be a problem for Panasas Inc 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13193 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-12-07 18:09:26 +00:00
Love Hörnquist Åstrand
283630104a prefix libasn1 types with heim_ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12439 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-07-15 14:05:49 +00:00
Johan Danielsson
242db364ce (fkt_remove_entry): check return value from start_seq_get (from Wynn 
Wilkes)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11471 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-24 16:43:30 +00:00
Johan Danielsson
e76e0dc990 check size of entry before trying to read 32-bit kvno; also fix typo 
in previous


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11025 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-05-28 12:57:27 +00:00
Johan Danielsson
ce0ace220b storage tweaks; also try to handle zero sized keytab files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10933 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-04-18 14:03:13 +00:00
Assar Westerlund
96dfbfc6f0 store the kvno % 256 as the byte and the complete 32 bit kvno after 
the end of the current keytab entry


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10871 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-03-10 23:14:36 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-14 06:14:52 +00:00
Assar Westerlund
d4cfdf5ad8 call krb5_set_error_string when open fails fatally 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9861 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-07 21:10:48 +00:00
Assar Westerlund
d2cba917ae (fkt_add_entry): store timestamp 
(fkt_next_entry_int): return timestamp


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7699 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-01-02 00:20:22 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Johan Danielsson
6bd5e351bf make krb5_fkt_ops const 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7072 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-10-03 14:45:25 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at} 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-16 21:39:11 +00:00
Assar Westerlund
c5b93f2925 remove O_BINARY 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6941 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-12 20:49:28 +00:00
Assar Westerlund
e70e38085d new files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6921 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-10 16:22:50 +00:00