Commit Graph

21 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Asanka C. Herath
3e8172f9e3 Initialize allocated memory in any_resolve()
Otherwise we might attempt to free an uninitialized pointer.
2010-12-02 01:18:02 -05:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hörnquist Åstrand
942a821fab remove RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
195710b52f add destroy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24434 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:43:24 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
e2a5f75799 make any_start_seq_get try more the then first keytab when looking for
keytab the first time.

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23880 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-08 16:15:34 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
3fd232eb32 N_()ify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23780 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-07 21:25:14 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
58bb9b742e use krb5_set_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23289 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 03:27:43 +00:00
Love Hörnquist Åstrand
db048d96d6 (any_next_entry): restructure to make it easier to read
Fixes Coverity, NetBSD CID#625


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17035 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-04-10 09:20:13 +00:00
Johan Danielsson
b411502ebe properly close the open keytabs (from Larry Greenfield)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11490 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-10-21 13:36:59 +00:00
Johan Danielsson
b6de4e7c52 use KRB5_KT_END instead of KRB5_CC_END
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10932 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-04-18 14:02:11 +00:00
Johan Danielsson
24c682162f implement add and remove
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10827 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-02-11 14:05:37 +00:00
Assar Westerlund
9c4c1af181 (any_resolve): make use of strsep_copy more consistent
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10188 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-24 02:22:33 +00:00
Assar Westerlund
af69003d76 (any_resolve); improving parsing of ANY:
(any_start_seq_get): remove a double free
(any_next_entry): iterate over all (sub) keytabs and avoid leave data
around to be freed again


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10187 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-24 01:50:52 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-05-14 06:14:52 +00:00
Assar Westerlund
456f8a7c9b new file
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9810 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-04-25 05:08:49 +00:00