oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,266 Commits 2 Branches 2 Tags
f0f07ff408031a76cf892515f5f72a0d5e30fabf
Commit Graph

69 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
00494ac136 use sl_did_you_mean 2011-11-22 12:21:15 -08:00
Nicolas Williams
dfc7ec92fa Make kadm5_lock() and unlock work, and add kadmin commands for them. 
The libkadm5 functions hdb_open() and close around all HDB ops.  This
meant the previous implementation of kadm5_lock() and unlock would
always result in a core dump.  Now we hdb_open() for write in
kadm5_lock() and hdb_close() in kadm5_unlock(), with all kadm5_s_*()
functions now not opening nor closing the HDB when the server context
keep_open flag is set.

Also, there's now kadmin(8) lock and unlock commands.  These are there
primarily as a way to test the kadm5_lock()/unlock() operations, but
MIT's kadmin.local also has lock/unlock commands, and these can be
useful for scripting (though they require much care).
 2011-07-22 21:07:48 -05:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Love Hornquist Astrand
433b1d5073 drop RCSID 2010-03-16 12:52:58 -07:00
Love Hörnquist Åstrand
c2ef08565c catch bad privs 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24875 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-27 03:34:34 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
9dd5de5ba6 Use hdb_db_dir(). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22253 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-09 06:00:00 +00:00
Love Hörnquist Åstrand
c993715525 (help): use sl_slc_help(). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17949 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-08-28 14:20:18 +00:00
Love Hörnquist Åstrand
652da91adb Rename u_intXX_t to uintXX_t 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17447 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-05-05 10:52:01 +00:00
Love Hörnquist Åstrand
5654000990 lower amount of shadow and const warnings 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15587 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-07-07 22:06:50 +00:00
Love Hörnquist Åstrand
2c5228c78d (main): catch -2 as EOF 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15101 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-09 15:35:22 +00:00
Love Hörnquist Åstrand
19d34445e7 (help): Don't use non-constant initializer for `fake'. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15057 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-05-02 19:10:19 +00:00
Love Hörnquist Åstrand
5921574969 add verifier libraries with kadm5_add_passwd_quality_verifier 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14803 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-04-15 11:16:32 +00:00
Johan Danielsson
fb4ab79bf4 inline sl_loop so we can more easily get a useful exit status 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14027 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-07-05 15:01:37 +00:00
Johan Danielsson
d970c48c81 print error messages to stderr; change all in-string quoting to use " 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14021 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-07-04 15:09:42 +00:00
Love Hörnquist Åstrand
dee8877cfa use kadm5_ad_init_with_password_ctx 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14011 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-27 22:54:02 +00:00
Johan Danielsson
138873b8b9 push local mode check to affected functions 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14007 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-27 17:32:14 +00:00
Johan Danielsson
9929f779ec move kadmin-commands.h from kadmin_locl.h so kadmind does not depend on it 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14000 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-27 15:04:07 +00:00
Johan Danielsson
d7f9fac88e convert to use slc; also add stash subcommand 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13970 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-21 19:19:45 +00:00
Love Hörnquist Åstrand
efbf822450 (main): keytab mode requires principal name 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13935 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-15 14:08:49 +00:00
Love Hörnquist Åstrand
4bae6714d1 if keyfile is set, pass in to libkadm5 
bug pointed out by Elrond <elrond@samba-tng.org>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13922 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-12 07:45:34 +00:00
Love Hörnquist Åstrand
594d3a7326 add --ad flag, XXX rewrite the init kadm5 interface 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13891 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-05-31 19:09:52 +00:00
Love Hörnquist Åstrand
f955d60539 add password-quality/pwq command 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13476 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-03-07 23:05:12 +00:00
Love Hörnquist Åstrand
9883b1f3e5 (main): use krb5_prepend_config_files_default, now all options in 
kdc.conf is parsed, not just [kdc]key-file=


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12585 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-08-18 06:03:42 +00:00
Love Hörnquist Åstrand
72fd1cf209 principal, not pricipal. From Thomas Klausner <wiz@netbsd.org> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11943 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-03-31 10:20:19 +00:00
Johan Danielsson
a93665b3fd add "del" alias for delete 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10458 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-08-10 08:06:13 +00:00
Assar Westerlund
0c88c2a721 (main): removed unused variable `e' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10438 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-08-05 06:57:06 +00:00
Johan Danielsson
807c15385c print help message on bad options 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10421 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-08-01 08:25:59 +00:00
Assar Westerlund
c295981a6d (main): some error cleaning required 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9953 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-15 06:34:35 +00:00
Assar Westerlund
49abdf5d33 new krb5_config_parse_file 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9941 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-14 06:17:58 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
b35114cad6 add --keytab / _K, from Leif Johansson <leifj@it.su.se> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9643 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-07 05:51:40 +00:00
Johan Danielsson
7c0cfca247 ignore SIGINT for now 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9511 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-26 22:20:52 +00:00
Assar Westerlund
633782864b (main): handle krb5_init_context failure consistently 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9443 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-31 08:05:03 +00:00
Johan Danielsson
77d4beacde add option parsing, and add privs' as an alias for privileges' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9046 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-09-10 19:20:49 +00:00
Johan Danielsson
03c2d820e6 quit' should be a alias for exit', not `help' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9037 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-09-10 17:54:06 +00:00
Assar Westerlund
704b589ecb (commands): add quit 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8810 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-25 02:15:08 +00:00
Assar Westerlund
8c022714c1 make help only print the commands that are actually available. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8178 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-04-12 10:27:11 +00:00
Assar Westerlund
a3c13cf202 (main): make parse errors a fatal error 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8089 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-04-02 21:27:35 +00:00
Assar Westerlund
7d0074908b unconfuse port usage 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7838 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-01-31 23:51:52 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Assar Westerlund
c725320081 add `del_enctype' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7435 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-11-25 22:32:26 +00:00
Assar Westerlund
c9d7ddc434 (usage): update usage string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6128 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-04 18:41:13 +00:00
Assar Westerlund
8130f64021 (main): send context to krb5_config_file_free 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6042 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-04-25 13:16:12 +00:00
Johan Danielsson
9c192a2804 complain about un-recognised commands 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5913 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-04-10 20:53:24 +00:00
Assar Westerlund
321667c4e0 (main): make code more consistent. always free configuration 
information.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5758 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-25 03:38:01 +00:00
Johan Danielsson
64d4aa49d8 use print_version 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5478 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-08 10:51:48 +00:00