Commit Graph

448 Commits

Author SHA1 Message Date
Nicolas Williams
a53f3a49e2 Fix unused variable warnings 2013-06-02 15:52:41 -05:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
97df66c0a0 Put Nd argument after Nd macro.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:27 -07:00
Love Hornquist Astrand
177122d8b9 use krb5_get_error_message for logging 2011-03-12 13:23:07 -08:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
ce28389265 Failed to open sockets. 2009-07-30 15:53:39 +02:00
Love Hornquist Astrand
4674f2dc6c Better length checks [CID-67] 2009-07-30 12:50:01 +02:00
Love Hornquist Astrand
f3cf321660 Fail harder (exit) in case of failure [CID-76] 2009-07-30 12:32:23 +02:00
Love Hornquist Astrand
2127d8d6bc free auth_context on close [CID-98] 2009-07-30 11:19:15 +02:00
Love Hornquist Astrand
20c376c62e Just fail if writing cookies failes [CID-100] 2009-07-30 10:52:23 +02:00
Love Hornquist Astrand
879051c308 Free sockets in cleanup function [CID-101] 2009-07-30 10:50:22 +02:00
Love Hörnquist Åstrand
4fc62a171c drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24525 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:16:23 +00:00
Love Hörnquist Åstrand
19fd3204c1 remove krb4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24524 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:16:05 +00:00
Love Hörnquist Åstrand
eef8fb4502 drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24523 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:15:44 +00:00
Love Hörnquist Åstrand
604fc696c9 drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24522 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:15:30 +00:00
Love Hörnquist Åstrand
df7f15d6cb drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24521 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:15:18 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
a49e8f06b8 no need to step p forward if we are not going to use it.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23515 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-11 10:01:16 +00:00
Love Hörnquist Åstrand
77c0066e58 Not init len, return never used (overwritten later).
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23490 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-11 09:58:44 +00:00
Love Hörnquist Åstrand
cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c rename des to hcrypto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
764927d1d9 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20453 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-19 20:04:40 +00:00
Love Hörnquist Åstrand
9d0c063d77 make encoding function independent of krb4 and krb5, enable removal of krb4
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20452 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-19 20:04:19 +00:00
Love Hörnquist Åstrand
c3340de01a revert previous
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18305 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 14:13:31 +00:00
Love Hörnquist Åstrand
f0c9af9324 Add man_MANS to EXTRA_DIST
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18304 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 14:13:30 +00:00
Love Hörnquist Åstrand
103231471e x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18293 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 10:18:16 +00:00
Love Hörnquist Åstrand
1dee1f3502 Add man_MANS to EXTRA_DIST
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18292 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 10:18:01 +00:00
Love Hörnquist Åstrand
7d627aac99 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17610 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-06-01 21:06:33 +00:00
Love Hörnquist Åstrand
5118c90498 Rename u_intXX_t to uintXX_t
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17450 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-05 11:11:43 +00:00
Love Hörnquist Åstrand
3a4c95a266 krb5_encrypt now takes a const, no need for casting
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15605 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 12:41:37 +00:00
Love Hörnquist Åstrand
9c3a22671f x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15602 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 02:21:53 +00:00
Love Hörnquist Åstrand
106c5e808e (doit): only cleaup for active sockets, passive does it own cleaning up
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15601 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 02:21:25 +00:00
Love Hörnquist Åstrand
5e969ca2b3 fix unconst and shadow warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15600 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 02:19:10 +00:00
Assar Westerlund
e59a9eb876 *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15575 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-07 20:06:53 +00:00
Assar Westerlund
f8c9e2d1ed Do not assume that des_key_schedule is an array.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15574 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-07 20:06:19 +00:00
Love Hörnquist Åstrand
956bab4cf0 (recv_conn): init variables to using them uninitialized
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15357 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-06-07 14:36:12 +00:00
Love Hörnquist Åstrand
79f3df1d57 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-30 14:11:59 +00:00
Love Hörnquist Åstrand
eeddeda3e7 (connect_host): make sure s is initialized
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15025 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-30 14:11:47 +00:00
Love Hörnquist Åstrand
ed16400376 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14863 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-20 10:39:45 +00:00
Love Hörnquist Åstrand
a4cd8b41d9 cast size_t to unsigned long
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14862 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-20 10:39:33 +00:00
Johan Danielsson
0624b4457e replace INCLUDES with AM_CPPFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14164 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-26 11:55:29 +00:00
Love Hörnquist Åstrand
e5d57f4517 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13531 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-15 18:20:21 +00:00
Love Hörnquist Åstrand
1aedcbce16 (krb5_destroy): free allocated memory, not something else
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13530 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-15 18:19:01 +00:00
Love Hörnquist Åstrand
c617bcd29c x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13459 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-07 17:25:30 +00:00
Love Hörnquist Åstrand
f1b20f9982 document new behavior
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13458 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-07 17:24:58 +00:00
Love Hörnquist Åstrand
7a0e97dd31 even if kx failes, start anyway
From: Harald Barth <haba@pdc.kth.se>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13457 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-07 17:22:06 +00:00