Commit Graph

30 Commits

Author SHA1 Message Date
Luke Howard 014f16883c libhcrypto: UI_UTIL_FLAG_VERIFY_SILENT 2018-12-30 15:39:49 -06:00
Jeffrey Altman 7b17e3015b YFS Coverity 11475
Change-Id: I3b6cde99859979e5db866c3f707f194144251ee1
2015-04-21 21:50:43 -04:00
Roland C. Dowdeswell e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand 0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Asanka C. Herath 880d728e02 Un-const as necessary to silence compiler warnings 2010-11-24 15:33:07 -05:00
Love Hornquist Astrand dde9ae659b drop RCSID 2010-03-16 12:50:09 -07:00
Asanka Herath b191b1e12f Make kdc build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 22:19:37 -08:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand c89e9af8ec Use hdb_db_dir().
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22244 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-08 23:47:42 +00:00
Love Hörnquist Åstrand bc686b4cbf s/random_key/random_key_flag/, From Dave Love <d.love@dl.ac.uk>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14515 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-01-17 13:40:08 +00:00
Love Hörnquist Åstrand beb5cf017d add --random-key
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14377 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-12-09 12:15:20 +00:00
Love Hörnquist Åstrand 54fc57ccb5 s/des_read_pw_string/UI_UTIL_read_pw_string/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12753 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 09:37:03 +00:00
Johan Danielsson e165bc3f98 constify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10922 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-04-18 09:47:25 +00:00
Assar Westerlund 74fd83ce59 include file name in error messages
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9621 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-01-30 17:08:35 +00:00
Johan Danielsson e181b0b525 fix typo, and remove unused option
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9021 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-09-01 16:30:25 +00:00
Johan Danielsson b6d34dc1a8 remove writing of old keyfile, and treat --convert-file as just
reading and writing the keyfile without asking for a new key


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8604 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-08 15:01:13 +00:00
Johan Danielsson 8e922c962d make this work with the new mkey code
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8550 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-05 13:16:35 +00:00
Assar Westerlund a69f4cf6dc signedness
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7376 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-11-13 04:18:09 +00:00
Assar Westerlund ff60b3d9ab (main): check return value from des_read_pw_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6966 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-14 21:45:46 +00:00
Johan Danielsson eceab8ed52 unlink keyfile on failure, chmod to 400
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6106 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-03 17:21:48 +00:00
Johan Danielsson 634a963513 add `--convert-file' option to change keytype of existing master key
file


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5388 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-02-20 14:47:49 +00:00
Johan Danielsson aaae186ab9 merge new-crypto branch
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5332 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-02-11 21:03:59 +00:00
Johan Danielsson c4fa75bb1a Remove unused variable.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3967 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-12 00:53:24 +00:00
Assar Westerlund 545297c6e4 roken_*
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3695 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-10-29 01:28:03 +00:00
Assar Westerlund 04eefedfad default to HDB_DB_DIR "/m-key"
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3417 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-09-07 23:26:38 +00:00
Johan Danielsson eab8b0bdfe Use headers.h. Add v4 m-keyfile support.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3326 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-09-01 15:54:14 +00:00
Johan Danielsson 44eb85c3ea kstash
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2602 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-24 07:45:48 +00:00