Commit Graph

30 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Nicolas Williams
7d7624f7f7 Fix CVE-2011-4862 Buffer overflow in libtelnet/encrypt.c in telnetd
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-4862
    http://security.freebsd.org/advisories/FreeBSD-SA-11:08.telnetd.asc
    http://security.freebsd.org/patches/SA-11:08/telnetd.patch
2011-12-28 17:50:30 -06:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
56f2ac7ff1 move encrypt.h and misc.h later
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23262 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-21 15:22:56 +00:00
Love Hörnquist Åstrand
fe5323f0e5 use unsigned/size_t where approprite
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22895 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:52:20 +00:00
Love Hörnquist Åstrand
c01934528b Spelling.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16802 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-23 19:36:31 +00:00
Johan Danielsson
e262f873e5 commit some forgotten changes
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10809 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-01-18 12:58:49 +00:00
Assar Westerlund
d7b1813e1e (encrypt_init, Name): const-ify
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7807 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-01-18 03:10:35 +00:00
Assar Westerlund
5c4a9b57f0 s/net_write/telnet_net_write/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5072 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-07-09 23:16:40 +00:00
Assar Westerlund
e9fea047b0 random fixes to make it build with socks
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5028 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-06-13 00:06:56 +00:00
Assar Westerlund
2244037704 less warnings (some static-ization)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3745 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-02 03:58:03 +00:00
Johan Danielsson
b9ef384206 encrypt_delay
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3504 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-09-18 15:12:02 +00:00
Björn Groenvall
4b6d3e99e6 Made things compile with socks5-v1.0r1.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1748 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-20 18:40:42 +00:00
Assar Westerlund
5bd22f427a more roken.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1637 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-02 14:44:09 +00:00
Assar Westerlund
dd02a92a8b replace sprintf all over the place
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1635 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-02 14:29:33 +00:00
Assar Westerlund
3d7c57acdb clean-up
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1187 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-01-24 23:13:35 +00:00
Assar Westerlund
239db0f710 removed all stupid register declarations
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1033 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 20:04:43 +00:00
Johan Danielsson
74c0bb16f5 Protoize
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@992 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 00:04:20 +00:00
Assar Westerlund
edb66c9354 SOCKS-support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@860 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-18 05:35:32 +00:00
Björn Groenvall
f565996a72 Minor fixup
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@261 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-11 17:22:54 +00:00
Unknown User d91-jda
a9e3c2cdb5 Variable encrypt_verbose had to be turned on in main.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@253 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-11 09:50:08 +00:00
Assar Westerlund
dc5ac35a7b encrypt_verbose by default
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@248 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-11 04:19:41 +00:00
Unknown User d91-jda
74f17a8ba2 Print message about not encrypting when receiving WONT or DONT encrypt.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@247 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-11 04:09:28 +00:00
Assar Westerlund
62641fb212 removed multiple defined variables
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@245 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-02-11 00:38:02 +00:00
Björn Groenvall
67f906f599 Added RCSID("$Id$");
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@206 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-12-27 13:25:39 +00:00
Unknown User d91-jda
a445da10c5 More ANSI/ISO 9899-1990 to the people!
Now actually builds (not including util) with DEC "cc -std1" and Sun
"acc -Xc".  There are still major prototype conflicts, but there isn't
much to do about this.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@192 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-11-12 20:22:06 +00:00
Unknown User d91-jda
022a6e8063 *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@105 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-09-14 15:43:49 +00:00
Unknown User d91-jda
518172f226 Added support for autoconf
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@57 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-07-19 23:47:00 +00:00
Unknown User d91-jda
e9eb97b897 Initial revision
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@50 ec53bebd-3082-4978-b11e-865c3cabbd6b
1995-07-17 15:42:43 +00:00