Roland C. Dowdeswell
cc47c8fa7b
Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
...
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer. Note that we get different
warnings on different machines and so this will be a work in
progress. So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).
Notably, we fixed
1. a lot of missing structure initialisers,
2. unchecked return values for functions that glibc
marks as __attribute__((warn-unused-result)),
3. made minor modifications to slc and asn1_compile
which can generate code which generates warnings,
and
4. a few stragglers here and there.
We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g. rsh, rcp,
popper, ftp and telnet.
Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.
We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Nicolas Williams
7d7624f7f7
Fix CVE-2011-4862 Buffer overflow in libtelnet/encrypt.c in telnetd
...
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-4862
http://security.freebsd.org/advisories/FreeBSD-SA-11:08.telnetd.asc
http://security.freebsd.org/patches/SA-11:08/telnetd.patch
2011-12-28 17:50:30 -06:00
Nicolas Williams
40a7d4b62f
More fixes for -Werror (GCC 4.6 catches more stuff)
2011-11-02 23:20:55 -05:00
Nicolas Williams
3bebbe5323
Fixes to make Heimdal -Wall -Werror clean
...
These fixes make developer mode build, at least on Ubuntu.
2011-11-02 21:42:08 -05:00
Love Hörnquist Åstrand
c97322adf2
fix compile warning
2011-07-24 15:46:11 -07:00
Marc Balmer
ae9ac01f3f
Typo
...
Signed-off-by: Love Hörnquist Åstrand <lha@h5l.org >
2011-07-24 10:29:47 -07:00
Love Hörnquist Åstrand
7aaba443bc
add NTMakefile and windows directories
2011-07-17 12:16:59 -07:00
Love Hornquist Astrand
0879b9831a
remove trailing whitespace
2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
c6bbdb545b
First drop of Windows build infrastructure from Secure Endpoints
2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
c7f51c8c5b
use krb5_make_principal
2009-10-04 11:29:20 -07:00
Love Hornquist Astrand
276867b63e
Free the full keyblock and not just the content [CID-173]
2009-07-30 09:54:45 +02:00
Love Hornquist Astrand
e8c46282ee
Free keyblock when krb5_mk_rep() failes [CID-174]
2009-07-30 09:51:00 +02:00
Love Hörnquist Åstrand
131474b736
remove krb4
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24520 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:15:02 +00:00
Love Hörnquist Åstrand
d5088379e8
drop krbv4 support
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24519 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:14:49 +00:00
Love Hörnquist Åstrand
57ed4efd37
drop krbv4 support
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24517 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:14:20 +00:00
Love Hörnquist Åstrand
cd4909239a
drop krbv4 support
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24515 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:13:50 +00:00
Love Hörnquist Åstrand
25a7b258ea
make sure we dont print off the end of the gss_buffer_t, they are defined to not included NULL, in heimdal they are but thats an implementation detail, dont teach people about that. From: Christian Krause
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24035 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-11-12 04:19:52 +00:00
Love Hörnquist Åstrand
6937d41a02
remove trailing whitespace
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
7050354151
more includes files for solaris.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23313 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-23 04:27:18 +00:00
Love Hörnquist Åstrand
56f2ac7ff1
move encrypt.h and misc.h later
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23262 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-06-21 15:22:56 +00:00
Love Hörnquist Åstrand
d2ecc5a8af
Use RAND_bytes() + DES_is_weak_key() to generate random DES
...
key. Introdunce random by feeding the des session key into the random
pool when the keys is recived instead of encrypt the random key with
the kerberos key.
This avoid depenency on DES_new_random_key() that doesn't exists in OpenSSL.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23091 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-27 18:49:41 +00:00
Love Hörnquist Åstrand
bdc1855499
No need to call DES_init_random_number_generator, hcrypto is sane now.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23034 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-18 10:01:54 +00:00
Love Hörnquist Åstrand
aa080e84ce
Use DES_new_random_key().
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23032 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-18 10:01:40 +00:00
Love Hörnquist Åstrand
fe5323f0e5
use unsigned/size_t where approprite
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22895 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:52:20 +00:00
Love Hörnquist Åstrand
254f650128
Use size_t where appropriate.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22891 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:52:03 +00:00
Love Hörnquist Åstrand
b077706b1d
Use size_t where appropriate.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22890 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:51:58 +00:00
Love Hörnquist Åstrand
5fed824f37
its vs it\'s etc. From Bjorn Sandell
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22071 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-11-14 20:04:50 +00:00
Love Hörnquist Åstrand
cc4333b758
remove cvs ignore files
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c
rename des to hcrypto
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
9d9e47cb42
(kerberos5_forward): use KDCOptions2int on flags before passing them
...
to krb5_get_forwarded_creds.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17991 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-09-04 12:37:02 +00:00
Love Hörnquist Åstrand
5118c90498
Rename u_intXX_t to uintXX_t
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17450 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-05 11:11:43 +00:00
Love Hörnquist Åstrand
c01934528b
Spelling.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16802 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-03-23 19:36:31 +00:00
Johan Danielsson
1b8bdba909
rename foo to ap_msg
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16502 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-09 16:40:11 +00:00
Johan Danielsson
9bd626b2eb
(kerberos5_is): also syslog all messages printed in auth_debug_mode
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16501 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-09 16:39:38 +00:00
Love Hörnquist Åstrand
f7f36911ed
(Data): Use right variable. From Tomas Olsson
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16263 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-31 09:27:36 +00:00
Love Hörnquist Åstrand
af8272f96c
Check return value from asprintf instead of string != NULL since it
...
undefined behavior on Linux. From Björn Sandell
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16223 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 17:09:06 +00:00
Love Hörnquist Åstrand
8b804c1012
Check return value from asprintf instead of string != NULL since it
...
undefined behavior on Linux. From Björn Sandell
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16222 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 16:57:04 +00:00
Assar Westerlund
f8c9e2d1ed
Do not assume that des_key_schedule is an array.
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15574 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-07 20:06:19 +00:00
Love Hörnquist Åstrand
13525ea454
case uid_t to unsigned long in printf format
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15246 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-27 13:47:20 +00:00
Love Hörnquist Åstrand
07757ea5a2
use DES_set_key_checked
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14681 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-03-23 16:19:31 +00:00
Johan Danielsson
0624b4457e
replace INCLUDES with AM_CPPFLAGS
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14164 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-26 11:55:29 +00:00
Love Hörnquist Åstrand
ebd6d7be6e
(Data): allocate the data needed to be send
...
From: MAAAAA MOOOR <huaraz@btinternet.com >
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13939 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-20 16:57:51 +00:00
Love Hörnquist Åstrand
03f9a30177
use new DES_ api
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12754 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 09:37:27 +00:00
Johan Danielsson
549c2f9d5f
also try to use the session key (if this is really correct is beyond
...
me, RFC2942 in unclear on this point)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11470 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-20 14:37:46 +00:00
Johan Danielsson
d0f02062c7
(kerberos5_is): check that the subkey is non-NULL
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11469 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-20 14:12:57 +00:00
Johan Danielsson
77de2f4011
use crypto-headers.h
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11444 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-10 20:03:49 +00:00
Johan Danielsson
ccf0fabb51
set AP_OPTS_USE_SUBKEY
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11324 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-02 15:33:20 +00:00
Johan Danielsson
8ffc68bb79
kerberos5_set_forward{,able} protos
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11288 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-08-28 20:56:14 +00:00
Johan Danielsson
e8c18ff436
add kerberos5_set_forward{,able} functions suitable for the command parser
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11287 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-08-28 20:55:53 +00:00
Johan Danielsson
31ad1085bf
use sysconfdir
...
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11080 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-08-12 15:09:20 +00:00