Commit Graph

404 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Nicolas Williams
3bebbe5323 Fixes to make Heimdal -Wall -Werror clean
These fixes make developer mode build, at least on Ubuntu.
2011-11-02 21:42:08 -05:00
Love Hörnquist Åstrand
fc3b4fcd3e drop unused KRB4 bits 2011-07-30 14:17:09 -07:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
97df66c0a0 Put Nd argument after Nd macro.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:27 -07:00
Thomas Klausner
db8e287e41 Use "Fl Fl" for long options.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:14 -07:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
d8db9d5a5a Free get_options on failure [CID-119] 2009-07-30 10:30:20 +02:00
Love Hörnquist Åstrand
00c521c6e2 remove krb4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24501 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:10:33 +00:00
Love Hörnquist Åstrand
ada58d9cd3 Additional patch from Christan Krause to handle asprintf better
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24041 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-11-15 04:43:42 +00:00
Love Hörnquist Åstrand
25a7b258ea make sure we dont print off the end of the gss_buffer_t, they are defined to not included NULL, in heimdal they are but thats an implementation detail, dont teach people about that. From: Christian Krause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24035 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-11-12 04:19:52 +00:00
Love Hörnquist Åstrand
4019104f4e fix comment
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23983 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-26 18:25:34 +00:00
Love Hörnquist Åstrand
28b7a2063e (pop_msg): make format const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23962 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-26 18:21:44 +00:00
Love Hörnquist Åstrand
19a15ffe1c (pop_msg): make format const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23961 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-26 18:21:33 +00:00
Love Hörnquist Åstrand
5e35a4cf44 make standard_error a const string.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23960 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-26 18:21:22 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand
7ba2b2006c rename des to hcrypto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand
240d98f20f x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19079 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-11-20 18:14:57 +00:00
Love Hörnquist Åstrand
ece5f9603e Make krb5_get_init_creds_opt_free take a context argument.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19078 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-11-20 18:12:41 +00:00
Love Hörnquist Åstrand
f0c9af9324 Add man_MANS to EXTRA_DIST
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18304 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 14:13:30 +00:00
Love Hörnquist Åstrand
5b5bde55dd x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18303 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-07 14:10:51 +00:00
Love Hörnquist Åstrand
7d627aac99 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17610 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-06-01 21:06:33 +00:00
Love Hörnquist Åstrand
5118c90498 Rename u_intXX_t to uintXX_t
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17450 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-05 11:11:43 +00:00
Love Hörnquist Åstrand
74a52646aa add missing }
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16226 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 21:13:53 +00:00
Love Hörnquist Åstrand
5f70cc361a x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16217 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 13:16:07 +00:00
Love Hörnquist Åstrand
9dccedb6d3 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16216 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 13:15:43 +00:00
Love Hörnquist Åstrand
07959751e8 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15290 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-29 21:47:01 +00:00
Love Hörnquist Åstrand
b56ac0785a avoid 'unused variable' warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15289 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-29 21:44:30 +00:00
Love Hörnquist Åstrand
8429cf6bbb x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15121 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-11 07:35:37 +00:00
Love Hörnquist Åstrand
958160a533 Include <crypt.h>.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15120 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-11 07:35:04 +00:00
Johan Danielsson
8746bf1201 (tgets): return whatever fgets returns
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14321 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-10-25 14:02:00 +00:00
Johan Danielsson
21c92cce06 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14174 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-27 12:51:20 +00:00
Johan Danielsson
8047dfc92e add message to NOOP result to appease gcc
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14173 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-27 12:49:52 +00:00
Johan Danielsson
0624b4457e replace INCLUDES with AM_CPPFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14164 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-26 11:55:29 +00:00
Johan Danielsson
2f2539dc17 add sasl and add some more text to a few options
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14047 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-14 09:14:47 +00:00
Johan Danielsson
af397098f4 (auth_loop): actually logging the user in is a good idea
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14046 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-14 09:11:52 +00:00
Johan Danielsson
bab19f3ade proto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14045 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-14 09:10:30 +00:00
Johan Danielsson
80c7ee4fba (pop_pass): put login code in separate function
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14044 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-14 09:10:06 +00:00
Johan Danielsson
252c9a30bc rename -a "none" to "plaintext", also bail out if requesting
unsupported auth method


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14043 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-07-14 09:04:34 +00:00
Johan Danielsson
688642aa4c fix license text
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13932 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-15 11:24:21 +00:00
Johan Danielsson
9d43255c82 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13931 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:20:14 +00:00
Johan Danielsson
35045237de SASL
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13930 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:19:24 +00:00
Johan Danielsson
a0d8310e75 improved SASL support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13929 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:19:05 +00:00
Johan Danielsson
8dbbc95b53 add SASL hooks
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13928 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:18:18 +00:00
Johan Danielsson
d2e71b5db5 if using SASL, don't allow plaintext USER/PASS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13927 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:14:16 +00:00
Johan Danielsson
0985fdc628 recognise sasl auth level
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13926 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-14 08:13:25 +00:00