oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,316 Commits 2 Branches 2 Tags
dca1de8dc80d8b78680719a1d2f74d6b9c99390c
Commit Graph

85 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
ce28389265 Failed to open sockets. 2009-07-30 15:53:39 +02:00
Love Hornquist Astrand
20c376c62e Just fail if writing cookies failes [CID-100] 2009-07-30 10:52:23 +02:00
Love Hörnquist Åstrand
df7f15d6cb drop krbv4 support 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24521 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-26 01:15:18 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
a49e8f06b8 no need to step p forward if we are not going to use it. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23515 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-08-11 10:01:16 +00:00
Love Hörnquist Åstrand
77c0066e58 Not init len, return never used (overwritten later). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23490 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-08-11 09:58:44 +00:00
Love Hörnquist Åstrand
9d0c063d77 make encoding function independent of krb4 and krb5, enable removal of krb4 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20452 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-04-19 20:04:19 +00:00
Love Hörnquist Åstrand
5118c90498 Rename u_intXX_t to uintXX_t 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17450 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-05-05 11:11:43 +00:00
Love Hörnquist Åstrand
5e969ca2b3 fix unconst and shadow warnings 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15600 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-07-09 02:19:10 +00:00
Love Hörnquist Åstrand
eeddeda3e7 (connect_host): make sure s is initialized 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15025 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-04-30 14:11:47 +00:00
Johan Danielsson
3e0f008990 (doit_{passive,active}): use kc->thataddr directly 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12058 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 17:33:02 +00:00
Johan Danielsson
8f06415a58 don't directly use sockaddr_storage, since we can't always know what 
it looks like


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12055 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 16:45:43 +00:00
Johan Danielsson
9c64357fd7 (connect_host): pass size of thisaddr_ss to getsockname 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11560 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-12-11 15:00:42 +00:00
Johan Danielsson
c0a3a2220c some ipv6 support (from Love) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11477 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-10-15 16:48:46 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
03886eeeaa (doit_active): check that fds are not too large to select on 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9100 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-10-08 13:21:17 +00:00
Assar Westerlund
5f648d3799 use socklen_t where appropriate instead of int 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8923 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-08-09 20:53:11 +00:00
Assar Westerlund
c34d277657 (connect_host): typo 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7550 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-06 16:46:46 +00:00
Assar Westerlund
2afff852fe (connect_host): use getaddrinfo 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7497 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-04 18:05:50 +00:00
Johan Danielsson
3ca5f8150f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 16:58:55 +00:00
Assar Westerlund
ac5267f34c (main): redo the v4/v5 selection for consistency. 
-4 -> try only v4
-5 -> try only v5
none, -45 -> try v5, v4


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7297 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-11-02 22:45:10 +00:00
Assar Westerlund
86b1e4bb18 conditionalize krb_enable_debug 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6345 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-06-23 06:14:49 +00:00
Assar Westerlund
cbaf3ff4c6 use get_default_username and resulting const pollution 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6309 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-06-15 02:37:24 +00:00
Assar Westerlund
6297205670 (main): don't byte-swap the argument to krb5_getportbyname 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6274 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-22 13:51:43 +00:00
Assar Westerlund
919478243a (main): try to use $USERNAME 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6261 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-21 09:22:29 +00:00
Assar Westerlund
a8b9a6de34 udpate comments 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6216 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-12 17:57:26 +00:00
Assar Westerlund
3ea2158a91 (main): forgot to conditionalize some KRB5 code 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6186 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-10 00:53:46 +00:00
Assar Westerlund
3447488a94 (main): use getarg 
(*): handle v4 and/or v5


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6183 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-10 00:16:50 +00:00
Assar Westerlund
8afe7e97ba (doit_active): handle error code from create_and_write_cookie 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6155 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-08 01:24:48 +00:00
Johan Danielsson
fbc35e40e6 add gcc-braces 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5626 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-19 14:12:29 +00:00
Assar Westerlund
2fcba2d23b (doit_passive): parse $DISPLAY correctly 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5192 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-11-18 09:24:44 +00:00
Assar Westerlund
3fea91fe51 (doit_active): check DISPLAY to figure out what local socket to 
connect to.  From Åke Sandgren <ake@cs.umu.se>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5175 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-10-02 04:34:49 +00:00
Assar Westerlund
5cf825f3bf fix from Ake Sandgren <ake@cs.umu.se> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-09-29 00:22:01 +00:00
Assar Westerlund
4de2a1b587 (doit_active): minor fix 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5140 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-08-31 19:39:10 +00:00
Assar Westerlund
dc0dfabdfe implement support for Solaris's named-pipe X transport 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5121 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-08-16 16:35:13 +00:00
Johan Danielsson
a5f54865d4 merge strcpy_truncate branch 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5027 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-06-09 19:25:40 +00:00
Johan Danielsson
47606d9547 get_xsockets returns int, not unsigned 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4962 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-05-28 15:20:33 +00:00
Johan Danielsson
33938ad8fc krb_enable_debug 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4955 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-05-26 15:41:14 +00:00
Assar Westerlund
228ed9b74a unifdef -DHAVE_H_ERRNO 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4828 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-05-01 05:16:55 +00:00
Assar Westerlund
d40ea8305f updated copyright 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4603 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-03-18 22:31:04 +00:00
Assar Westerlund
5b996a53ae use new get_xsockets 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4602 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-03-18 22:30:53 +00:00
Assar Westerlund
9e36ab86f3 check malloc and strdup 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4129 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-12-05 04:26:29 +00:00
Johan Danielsson
496e2c0ec8 Move tmp-file creation to create_and_write_cookie. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3877 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-11-09 11:14:28 +00:00
Assar Westerlund
a9b53f61df more intelligent check for passive mode 
new option `-P' to force passive mode


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3331 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-09-01 15:58:55 +00:00
Assar Westerlund
f667b46ddf try to give a better error message (than a core dump :-) when talking 
to an old kxd.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1727 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-05-18 18:53:06 +00:00
Assar Westerlund
dd02a92a8b replace sprintf all over the place 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1635 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-05-02 14:29:33 +00:00
Johan Danielsson
e1282e7dfc Update copyright strings. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1541 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1997-04-01 08:19:18 +00:00