Commit Graph

23 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hörnquist Åstrand
c61f9fcbe9 drop simple_execl
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24340 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:27:59 +00:00
Love Hörnquist Åstrand
3ad1d78d63 make roken not provide environ, its really something that doesnt work in a multinamespace enviroments (read mac os x)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23943 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-19 04:57:42 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
5cd0815781 use "roken.h" consitantly
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21005 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:54:35 +00:00
Love Hörnquist Åstrand
9df9f6a9da revert 21003
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21004 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:53:10 +00:00
Love Hörnquist Åstrand
12df8538af use "roken.h" consitantly
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21003 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-08 01:42:05 +00:00
Love Hörnquist Åstrand
043e2fb6c6 don't close stderr, close all fd that is num 3 and larger
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14782 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-13 11:39:00 +00:00
Love Hörnquist Åstrand
d15c9d7cc6 (pipe_execv): use closefrom
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14780 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-13 08:05:03 +00:00
Love Hörnquist Åstrand
709aa58c74 define ROKEN_LIB_FUNCTION on all exported functions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14773 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-12 11:29:18 +00:00
Love Hörnquist Åstrand
0e44e47b2a add timed simple_exec
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13342 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-02-12 14:37:18 +00:00
Assar Westerlund
7a6618569d (pipe_execv): remove unused variable
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10146 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-21 03:38:03 +00:00
Johan Danielsson
99c4509d73 rename check_status to wait_for_process, and export it; function
pipe_execv similar to popen, but with more control over input and
output


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10132 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-19 23:53:23 +00:00
Johan Danielsson
10fed5bc89 simple_execl
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9135 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-11-05 16:41:06 +00:00
Assar Westerlund
e1b38a9f91 use vstrcollect
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7785 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-01-09 10:58:51 +00:00
Johan Danielsson
3ca5f8150f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 16:58:55 +00:00
Johan Danielsson
1b74520da7 add simple_exec{ve,le}
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6773 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-09 14:01:48 +00:00
Assar Westerlund
90b9af1cea add <roken.h>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5643 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-03-20 02:43:16 +00:00
Assar Westerlund
6de4bc8eb9 (simple_execvp): loop around waitpid when errno == EINTR
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5098 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-07-24 09:53:57 +00:00
Assar Westerlund
ccafc157c7 (simple_execlp): initialize `argv'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5089 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-07-22 13:07:14 +00:00
Johan Danielsson
abbc3b68d5 Simple fork+exec system() replacement.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4607 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-03-19 19:41:19 +00:00