Commit Graph

334 Commits

Author SHA1 Message Date
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand 7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand 0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Asanka Herath d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand 705e50b079 Check name before using it [CID-43] 2009-07-30 13:48:39 +02:00
Love Hörnquist Åstrand 67612f57da fix warning
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24571 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-04 22:02:57 +00:00
Love Hörnquist Åstrand da6c344eec drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24518 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:14:34 +00:00
Love Hörnquist Åstrand 0a03359817 drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24514 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:13:33 +00:00
Love Hörnquist Åstrand 3ad1d78d63 make roken not provide environ, its really something that doesnt work in a multinamespace enviroments (read mac os x)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23943 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-19 04:57:42 +00:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand 5f47850b7e Really, mac os uses wtmpx (or asl).
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22953 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-10 10:44:23 +00:00
Love Hörnquist Åstrand fe5323f0e5 use unsigned/size_t where approprite
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22895 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 18:52:20 +00:00
Love Hörnquist Åstrand bdd75a7ca8 Dont need to set this as the controlling PTY on steams sockets, don't
abort on failure. From Harald Barth and Ian Delahorne.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22665 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-03-09 21:47:53 +00:00
Love Hörnquist Åstrand 39733fdb03 Use strlcpy instead of strncpy, thanks to Antoine Brodin.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22390 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-31 10:12:48 +00:00
Love Hörnquist Åstrand 28dc596f15 (usage): use exit_code, add --version and --help.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21748 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-07-31 18:57:20 +00:00
Love Hörnquist Åstrand cd48123810 Add --help.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21732 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-07-31 01:40:30 +00:00
Love Hörnquist Åstrand 3d31f777e0 Remove leftover.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21520 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-07-12 13:11:49 +00:00
Love Hörnquist Åstrand 578a6f5594 GLIBC made the choice that ut_tv should be shared between 32 and 64
bit platforms so now we can no longer use struct timeval functions to
compare or set/get data that uses pointer (gettimeofday for example)
since ut_tv is now not a struct timeval but rather a struct { int32_t
tv_sec; int32_t tv_usec; };


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21518 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-07-12 13:04:50 +00:00
Love Hörnquist Åstrand cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand 7ba2b2006c rename des to hcrypto
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20466 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-04-20 08:29:05 +00:00
Love Hörnquist Åstrand 585ce9cbb0 HP/UX defines SE in sys/uio.h, #undef it.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18757 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 15:47:35 +00:00
Love Hörnquist Åstrand e7c62c79bb Fix spelling.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18742 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 13:37:28 +00:00
Love Hörnquist Åstrand 489987bee3 Dont't include some streamspty headers here.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18728 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 00:09:25 +00:00
Love Hörnquist Åstrand a8d177955e includes some STREAMSPTY header here to avoid ioctl vs socket_wrapper horror.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18727 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 00:08:28 +00:00
Love Hörnquist Åstrand d8fb637ef8 more files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18663 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-20 17:09:30 +00:00
Love Hörnquist Åstrand 62e15d7f6b Add documentation for -e, require encryption.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18113 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-09-19 08:27:40 +00:00
Love Hörnquist Åstrand b6e0a49796 Add require_encryption.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18112 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-09-19 08:26:50 +00:00
Love Hörnquist Åstrand 4adf47957d Allow encryption to be required, wait to the client to turn it on, if
failes, refuse the connection.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18111 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-09-19 08:26:21 +00:00
Love Hörnquist Åstrand ead5f1b7b6 If encryption is required, don't allow it to be turned off.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18110 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-09-19 08:25:20 +00:00
Love Hörnquist Åstrand 477270a1ca remove setlinebuf that sneeked in
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16334 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-12-01 15:29:40 +00:00
Love Hörnquist Åstrand ea8a943e6d Initialize the slc mapping table before its used.
Based on bugraport from Russell Sanford <rrs@clyde.dcccd.edu>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16331 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-12-01 15:25:45 +00:00
Johan Danielsson 2807ca723b remove newline from syslog string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16284 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-11-03 16:40:05 +00:00
Love Hörnquist Åstrand cac19c86e7 Fix printing of /etc/issue{,.net}.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15845 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:37:04 +00:00
Love Hörnquist Åstrand 44c8c17c29 make writenet take const void * and size_t, abort if size it too large
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15844 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:36:16 +00:00
Love Hörnquist Åstrand 33ec7be97f Fix ansi c warning.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15843 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:35:39 +00:00
Love Hörnquist Åstrand da3079056e no need to typecast argument to writenet
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15842 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:35:04 +00:00
Love Hörnquist Åstrand 671b1a284f make writenet take const void * and size_t
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15841 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 13:34:26 +00:00
Love Hörnquist Åstrand b5bf953b97 (set_termbuf): use {} around if to make else unambiguous
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15245 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-27 13:42:04 +00:00
Love Hörnquist Åstrand 3fe17e04c4 (start_login): put utmpx code into a new scope to avoid pre c99 problems.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15196 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-20 08:35:51 +00:00
Johan Danielsson 40b1dab5bd (start_login): set encryption pointers to NULL, so we don't try to do
either


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15138 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-13 14:20:38 +00:00
Johan Danielsson 60fe67f93b (putf): %t: the regular and streamspty case are functionally
equivalent, so merge them, this also makes it work better on machines
that puts their devices in a subdirectory to /dev


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15003 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-28 16:36:32 +00:00
Love Hörnquist Åstrand a3bb5d884c (getpty): Declare p.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14967 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-27 08:02:18 +00:00
Love Hörnquist Åstrand 53624218c7 use strlcpy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14953 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-25 13:15:15 +00:00
Love Hörnquist Åstrand 5ff49eff33 remove another strcpy
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14939 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-24 20:59:35 +00:00
Love Hörnquist Åstrand 0ffd30a6e4 rewrite getpty to make use openpty when its found, save the slave fd
so that cleanopen can use it if its available


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14848 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-19 13:36:20 +00:00
Love Hörnquist Åstrand 7adcb73bb8 include krb5.h to avoid krb5_getportbyname warning
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14847 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-19 10:33:18 +00:00
Love Hörnquist Åstrand 50d9ed5566 clean_ttyname might be unused, mark it so with __attribute__
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14755 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-07 19:33:29 +00:00
Love Hörnquist Åstrand c41860a8ee use NULL as last argument to execl, not 0
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14747 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-06 11:23:54 +00:00
Love Hörnquist Åstrand 692e21b3e7 remove setting of DES_check_key, all code uses DES_set_key_checked
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14682 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-03-23 16:22:39 +00:00