oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,084 Commits 2 Branches 2 Tags
cc47c8fa7b0f4567bb9dd7e692c32a558a166d5c
Commit Graph

92 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
2ac7566997 Fix logic for adding digestAlgorithm, original patch from Douglas E Engert. 2011-05-17 07:43:42 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Jelmer Vernooij
36ade8b509 hx509: Make various functions used by Samba public. 
* hx509_cert_public_encrypt
* hx509_parse_private_key
* hx509_private_key_assign_rsa
* hx509_private_key_free
* hx509_private_key_private_decrypt
* hx509_private_key_init
* hx509_private_key2SPKI
* hx509_request_get_name
* hx509_request_get_SubjectPublicKeyInfo
* hx509_request_free
* hx509_request_init
* hx509_request_set_name
* hx509_request_set_SubjectPublicKeyInfo

Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2011-02-23 19:47:28 -08:00
Love Hornquist Astrand
667ec8eb81 Use version 0 for issuer name serial number and version 2 for ski 
Pointed by subject Michael Wood <esiotrot@gmail.com> on samba-technical
 2010-10-07 00:22:09 -07:00
Love Hornquist Astrand
739c79b76b don't add dup digestAlgorithms 2010-08-10 10:40:54 -07:00
Love Hornquist Astrand
4bb81d921d add HX509_CMS_SIGNATURE_NO_CERTS and HX509_CMS_SIGNATURE_LEAF_ONLY 2010-08-10 10:19:48 -07:00
Love Hornquist Astrand
b1eb65c5ba use hx509_certs_iter_f 2009-11-22 13:52:31 -08:00
Love Hörnquist Åstrand
2baa886d7a Use OID variable instead of function. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25240 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-28 01:18:43 +00:00
Love Hörnquist Åstrand
f6800d16eb catch memory leak 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25192 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-06 19:03:48 +00:00
Love Hörnquist Åstrand
3221f51f1c document flags 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24962 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-03-26 23:12:57 +00:00
Love Hörnquist Åstrand
15d0edc29a allow weak flags for cms 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24820 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-27 03:24:28 +00:00
Love Hörnquist Åstrand
ff5dab4f4a remove rcsid 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24795 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:28:18 +00:00
Love Hörnquist Åstrand
0d03799468 spelling 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24667 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-09 17:18:16 +00:00
Love Hörnquist Åstrand
1228f20e92 spelling and doxygen 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24591 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-04 22:06:22 +00:00
Love Hörnquist Åstrand
08e864fbe9 spelling 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24590 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-04 22:06:12 +00:00
Love Hörnquist Åstrand
90a9ed5fd2 Add hx509_cms_create_signed() that allows signing with 0 or more certs. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24580 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-04 22:04:28 +00:00
Love Hörnquist Åstrand
afb2abb65d Add HX509_CMS_VS_ALLOW_ZERO_SIGNER and HX509_CMS_VS_NO_VALIDATE 
Doxygen.

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24576 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-04 22:03:47 +00:00
Love Hörnquist Åstrand
26abb7e637 option to turn off the KeyUsage check in CMS verify SignedData 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24204 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-15 04:32:49 +00:00
Love Hörnquist Åstrand
61d49ed472 add options to skipping KeyUsage check 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24197 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-15 04:31:41 +00:00
Love Hörnquist Åstrand
ba69102e6b add flags to hx509_cms_verify_signed 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24192 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-15 04:30:52 +00:00
Love Hörnquist Åstrand
a40d246195 simplify CMS handling, coverity #158 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24089 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-11 04:57:40 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
9d452c8bd0 Pass in time_now to unevelope, us verify context time in verify_signed. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23268 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 03:23:47 +00:00
Love Hörnquist Åstrand
b3efcbda59 more documentation 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22327 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-15 04:49:37 +00:00
Love Hörnquist Åstrand
ceb99a8536 Doxygen documentation. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22320 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-15 03:00:41 +00:00
Love Hörnquist Åstrand
b1a669bf5e fix syntax error, from David Love. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22292 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-14 05:21:27 +00:00
Love Hörnquist Åstrand
d651f2187d More documentation 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22275 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-11 11:02:11 +00:00
Love Hörnquist Åstrand
5fed824f37 its vs it\'s etc. From Bjorn Sandell 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22071 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-11-14 20:04:50 +00:00
Love Hörnquist Åstrand
ef581cc5de remove stale comment. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21785 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-08-01 19:37:03 +00:00
Love Hörnquist Åstrand
a5e5db51bd Use hx509_crypto_random_iv. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21319 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-25 19:46:52 +00:00
Love Hörnquist Åstrand
bff0a5c11c Implement and use HX509_CMS_SIGATURE_ID_NAME. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21267 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-24 19:24:20 +00:00
Love Hörnquist Åstrand
f622a16e97 Add hx509_cert_init_data and use everywhere 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21085 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-13 06:39:53 +00:00
Love Hörnquist Åstrand
a93b07021f (hx509_cms_create_signed_1): Use hx509_peer_info to select the 
signature algorithm too.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20937 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-06 20:50:55 +00:00
Love Hörnquist Åstrand
dbb87065cd When we are not using pkcs7-data, avoid seing signedAttributes since 
some clients get upset by that (pkcs7 based or just plain broken).


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20926 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-05 17:21:58 +00:00
Love Hörnquist Åstrand
97b8a8f765 Use default AlgorithmIdentifier. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20791 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-02 02:30:58 +00:00
Love Hörnquist Åstrand
bb64783393 (hx509_cms_create_signed_1): if no eContentType is given, use pkcs7-data. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20664 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-05-10 22:53:44 +00:00
Love Hörnquist Åstrand
5f1b3a853b Add flags to generate detached signatures. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20168 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-02-03 22:45:20 +00:00
Love Hörnquist Åstrand
5820ca3c54 switch to sha256 as default digest for signinging 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20017 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-20 23:58:14 +00:00
Love Hörnquist Åstrand
698d712bfa (hx509_cms_create_signed_1): use hx509_cert_binary 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19912 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-14 23:28:58 +00:00
Love Hörnquist Åstrand
f865e18161 move _hx509_set_digest_alg from cms.c to crypto.c since its only used there. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19837 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-11 09:36:03 +00:00
Love Hörnquist Åstrand
18c21c9cc4 Avoid shadowing. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19835 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-11 09:28:42 +00:00
Love Hörnquist Åstrand
0e65b27793 Check for internal ASN1 encoder error. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19768 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-01-08 18:45:03 +00:00
Love Hörnquist Åstrand
ef6bf7a0fe (find_CMSIdentifier): require the certificate we are looking for to be valid. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19243 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-12-06 11:30:44 +00:00
Love Hörnquist Åstrand
d58d796709 (hx509_cms_create_signed_1): when building the path, omit the trust 
anchors.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19238 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-12-06 10:34:39 +00:00
Love Hörnquist Åstrand
a3ece41637 Provide time to _hx509_calculate_path so we don't send no longer valid certs to our peer. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19229 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-12-05 23:47:11 +00:00
Love Hörnquist Åstrand
66c417d257 (hx509_cms_verify_signed): specify what signature we failed to verify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19183 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-11-28 21:50:36 +00:00
Love Hörnquist Åstrand
1d8f59cfa1 sprinkle more error strings 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-11-28 12:00:08 +00:00