Commit Graph

128 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
3564726537 support NT_USER_NAME for real 2011-05-22 13:02:08 -07:00
Love Hornquist Astrand
9dc505a721 cred is no longer a name, handle that 2011-05-22 13:01:32 -07:00
Love Hornquist Astrand
26085dfbc0 allocate enough memory 2011-05-21 13:25:24 -07:00
Love Hornquist Astrand
58ffee93b7 allow GSS_C_NT_USER_NAME too 2011-05-21 13:07:22 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
1c10632690 Add define for ret 2011-05-17 21:21:20 -07:00
Jeffrey Altman
75959422e1 update gssapi/ntlm for windows build
NTMakefile:
  replace ntlm/inquire_cred.c with ntlm/creds.c
  add ntlm/inquire_sec_context_by_oid.c
  add ntlm/iter_cred.c

add missing GSSAPI_CALLCONV function descriptors

conditionalize use of kcm functions with HAVE_KCM

Change-Id: Ia693f67304405bd540c57db8858c13314cd60322
2011-05-17 12:02:11 -04:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Love Hornquist Astrand
df802c6298 add keys 2011-03-13 12:42:54 -07:00
Love Hornquist Astrand
35a072e574 add pac 2011-03-13 12:42:42 -07:00
Love Hornquist Astrand
c3905ff795 glue in some more functions 2011-03-12 19:29:00 -08:00
Love Hornquist Astrand
5dcf0753f4 fill in all mo that make sense for now 2010-11-25 23:52:43 -08:00
Love Hornquist Astrand
c1069f8a36 add _gss_oid_name_table 2010-11-25 20:20:03 -08:00
Love Hornquist Astrand
2eae1a1d30 spelling 2010-10-27 21:09:41 -07:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hornquist Astrand
1021099f3d rename external so that they can be included in array and struct initializer 2010-07-22 20:47:04 -07:00
Love Hornquist Astrand
2b1645aa08 catch error from as.*printf 2010-05-30 13:44:41 -07:00
Asanka Herath
ce7d784648 Avoid using 'interface' as a variable name 2009-11-24 10:11:16 -08:00
Asanka Herath
b1063ea8fc Initial Windows port 2009-11-24 10:11:14 -08:00
Love Hornquist Astrand
ab1b87b557 drop RCSID 2009-11-14 11:15:57 -08:00
Love Hornquist Astrand
a4881ea0d6 [HEIMDAL-646] malloc(0) checks for AIX 2009-10-11 18:04:43 -07:00
Love Hornquist Astrand
f030b4e59a free context 2009-08-27 18:30:29 -07:00
Love Hornquist Astrand
1999c85670 Make mech glue layer aware of composite mechs that uses mech glue layer credentials
This make it possible to use krb5/ntlm credentials with SPNEGO.
Needs some more work to avoid double fetching credentials.
2009-08-27 12:12:44 -07:00
Love Hornquist Astrand
9ccc79c5b6 Don't leak context if nsi_probe failes
Deduced from valgrind log produced by Markus Moeller
2009-08-22 10:52:22 -07:00
Love Hornquist Astrand
03cb3aa56b use EVP_MD_CTX_create 2009-08-20 17:13:09 -07:00
Love Hornquist Astrand
dfd1edb54d switch to use EVP interface instead of old MDX_ style interface 2009-08-17 10:20:01 +02:00
Love Hornquist Astrand
3608b815b4 Don't bother checking usage of minor_status [CID-23] 2009-07-30 14:01:57 +02:00
Love Hörnquist Åstrand
012eae7f34 rename gssapi/ntlm/digest.c to kdc.c since that is what its talking too
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25292 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-03 03:16:21 +00:00
Love Hörnquist Åstrand
eb9f8ba4bb output_name == NULL is invalid
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25201 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-09 14:21:05 +00:00
Love Hörnquist Åstrand
2049387687 add gsspi_ntml.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24542 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-30 16:47:12 +00:00
Love Hörnquist Åstrand
26cc8f6525 flatten namespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24482 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 20:49:54 +00:00
Love Hörnquist Åstrand
8a54aaba59 free name
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24142 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 05:06:54 +00:00
Love Hörnquist Åstrand
95b4de5cd1 check the right variable, cid#3
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24127 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 05:04:19 +00:00
Love Hörnquist Åstrand
7a8202a4d9 free name on error, cid#69
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24126 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 05:04:09 +00:00
Love Hörnquist Åstrand
d97b2360b9 free krb5_ccache on error, cid#49
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24125 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-12-11 05:03:58 +00:00
Love Hörnquist Åstrand
306628d12c switch to krb5_clear_error_message
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23916 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-14 02:56:37 +00:00
Love Hörnquist Åstrand
fe1a976ae2 new krb5_cc_cache_match
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23905 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-13 03:03:21 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
6562b287fb Always set output_cred_handle to GSS_C_NO_CREDENTIAL in the begining.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23688 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-26 12:35:12 +00:00
Love Hörnquist Åstrand
1106480143 output buffer always set
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23673 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-25 02:32:55 +00:00
Love Hörnquist Åstrand
59171e8164 minor status must be set.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23672 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-25 02:32:43 +00:00
Love Hörnquist Åstrand
6f68a07561 define HC_DEPRECATED_CRYPTO
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23614 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-17 15:57:12 +00:00
Love Hörnquist Åstrand
30d0d24121 catch error, zero out variable.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23546 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-16 23:00:20 +00:00
Love Hörnquist Åstrand
21f5c84036 Catch error
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23494 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-11 09:59:08 +00:00
Love Hörnquist Åstrand
96641812d5 close-on-exec
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23470 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-27 12:17:35 +00:00
Love Hörnquist Åstrand
82570534fc pass extra argument to krb5_cc_[gs]et_config.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23419 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-26 18:37:07 +00:00
Love Hörnquist Åstrand
77e2e6d550 restore username parsing
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23408 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-26 18:32:47 +00:00
Love Hörnquist Åstrand
23b129144f Use krb5_cc_get_config.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23395 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-26 18:26:49 +00:00