Commit Graph

14 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Asanka Herath
4c6cdf07c2 Fix calling convention for asn1 tests 2010-09-14 08:03:27 -04:00
Asanka Herath
6ab44f06a3 Windows: Fix tests in lib/asn1 2010-08-20 13:06:57 -04:00
Love Hornquist Astrand
b939943b07 first stange of asn1 table driven compiler 2009-11-21 10:24:56 -08:00
Love Hörnquist Åstrand
0e6b5c5c22 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25232 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-28 01:17:17 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
4bc030b1d6 Print size_t as (unsigned long) and cast.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18751 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 14:49:13 +00:00
Love Hörnquist Åstrand
244de82c02 Try to align data, IA64's gets upset if its unaligned.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18746 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-21 14:22:04 +00:00
Love Hörnquist Åstrand
84b70dac40 Avoid signedness warnings.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16059 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-09-13 19:40:30 +00:00
Love Hörnquist Åstrand
eaaf5d23fd (generic_decode_fail): only copy in if checklen its less then 0xffffff
and larger than 0.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15661 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-19 15:07:25 +00:00
Love Hörnquist Åstrand
b838707d0e Commit much improved ASN.1 compiler from joda-choice-branch.
Highlighs for the compiler is support for CHOICE and in general better
support for tags. This compiler support most of what is needed for
PK-INIT, LDAP, X.509, PKCS-12 and many other protocols.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15617 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-12 06:27:42 +00:00
Love Hörnquist Åstrand
515d17106c move generic asn1/der functions from check-der.c to here
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11600 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-01-23 10:21:56 +00:00