oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,084 Commits 2 Branches 2 Tags
cc47c8fa7b0f4567bb9dd7e692c32a558a166d5c
Commit Graph

16 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
b77ee0c2f8 Close f, from cppcheck 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25277 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-06-08 20:33:22 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
07482fe5ad Switch to krb5_set_password. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23398 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-26 18:28:07 +00:00
Love Hörnquist Åstrand
3154e1056e Use strcspn to remove \n from string returned by fgets. 
From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19233 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-12-06 08:04:05 +00:00
Love Hörnquist Åstrand
ece5f9603e Make krb5_get_init_creds_opt_free take a context argument. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19078 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-11-20 18:12:41 +00:00
Love Hörnquist Åstrand
b866404406 (read_words): catch empty file case, will cause PBE (division by zero) 
later. From Tobias Stoeckmann.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17001 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-04 14:19:13 +00:00
Johan Danielsson
26457b7135 replace krb5_free_creds_contents by krb5_free_cred_contents 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13790 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-04-25 19:25:35 +00:00
Love Hörnquist Åstrand
5d190295aa add context argument to krb5_get_init_creds_opt_alloc 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12783 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-09-08 15:28:20 +00:00
Love Hörnquist Åstrand
61e14619de use krb5_get_init_creds_opt_alloc/krb5_get_init_creds_opt_free 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12737 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-09-03 00:31:42 +00:00
Assar Westerlund
c2bc6aeecf (main): implement --version and --help 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10410 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-07-31 02:44:42 +00:00
Assar Westerlund
ebc693bff9 (nop_prompter): update prototype 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9931 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-12 15:17:10 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
e31d9ba4c2 (generate_requests): handle krb5_init_context failure consistently 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9436 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-31 07:49:27 +00:00
Assar Westerlund
24e07e6274 new test program 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8535 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-02 16:09:31 +00:00