oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,084 Commits 2 Branches 2 Tags
cc47c8fa7b0f4567bb9dd7e692c32a558a166d5c
Commit Graph

59 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas 
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
 2011-04-29 20:25:05 -07:00
Asanka C. Herath
880d728e02 Un-const as necessary to silence compiler warnings 2010-11-24 15:33:07 -05:00
Love Hornquist Astrand
dde9ae659b drop RCSID 2010-03-16 12:50:09 -07:00
Russ Allbery
3d715adc21 Rename the database after closing it in hpropd 
If a Berkeley DB database is used as the underlying database, renaming
the database before closing it can produce error messages like the
following on close:

/var/lib/heimdal-kdc/heimdal~.db: unable to flush: No such file or directory

since the underlying database library caches the old file name.  There
is a rename() method in the Berkeley DB API, but it also invalidates
the database handle and requires that it be reopened.  Since the
hdb_rename implementation does not require that the database be open,
close the database before renaming it to avoid this problem.

Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2010-02-02 13:27:48 -08:00
Asanka Herath
b191b1e12f Make kdc build on windows 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2009-11-24 22:19:37 -08:00
Asanka Herath
d00f9984a5 Make roken build on windows 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2009-11-24 21:42:02 -08:00
Love Hörnquist Åstrand
7665dbc0be openlog failed, exit 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24922 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-03-22 17:23:54 +00:00
Love Hörnquist Åstrand
a4b0d218d9 make db NULL to make it not pass undefined value to hdb_print_entry(). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24862 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-27 03:31:41 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
4ae3998346 Use hdb_default_db(). 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22245 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-12-08 23:48:52 +00:00
Love Hörnquist Åstrand
87e6051ddc (main): free the message when done with it. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20434 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-04-19 14:00:32 +00:00
Love Hörnquist Åstrand
e6e22c2bbd Remove support dumping to a kerberos 4 database. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18957 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-11-08 18:48:36 +00:00
Love Hörnquist Åstrand
562c2aced2 Adapt to signature change of _krb5_principalname2krb5_principal. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18349 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-08 13:43:52 +00:00
Love Hörnquist Åstrand
652da91adb Rename u_intXX_t to uintXX_t 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17447 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-05-05 10:52:01 +00:00
Love Hörnquist Åstrand
0c2369acd0 Wrap hdb_entry with hdb_entry_ex, patch originally from Andrew Bartlet 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16378 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-12-12 12:40:12 +00:00
Love Hörnquist Åstrand
7132a9b084 Merge in the libkdc/kdc configuration split from Andrew Bartlet <abartlet@samba.org> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15529 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-06-30 01:03:35 +00:00
Love Hörnquist Åstrand
90930940d1 include kerberos 4 headers here 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14916 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-04-24 13:48:37 +00:00
Love Hörnquist Åstrand
c5ac82a862 update (c) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14425 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-12-29 19:22:29 +00:00
Love Hörnquist Åstrand
6f41f39523 use private version of principalname 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14424 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-12-29 19:22:28 +00:00
Love Hörnquist Åstrand
0540f13b86 prefix all struct HDB elements with hdb_ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12880 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-09-19 00:25:35 +00:00
Love Hörnquist Åstrand
75252da59e s/strcat/strlcat/, inspired from openbsd 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12042 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-16 15:46:32 +00:00
Johan Danielsson
fc4f2a6921 constify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10925 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-04-18 10:18:50 +00:00
Johan Danielsson
2499b84bc7 add realm override option 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10725 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-09-18 09:54:15 +00:00
Assar Westerlund
2fb88a72e0 update to new krb5_auth_con* names 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10107 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-06-18 04:08:37 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
49eff91b5b (main): initalize fd_out for extra clarity 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9494 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-25 12:37:39 +00:00
Assar Westerlund
b912d83410 (main): handle EOF when reading from stdin 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9445 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-01-03 01:49:36 +00:00
Assar Westerlund
7e4da1415d use socklen_t where appropriate instead of int. From <thorpej@netbsd.org> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8920 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-08-09 20:44:30 +00:00
Assar Westerlund
b1564c84c3 (main): check that the ticket was for `hprop/' for paranoid reasons 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8790 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-23 21:32:42 +00:00
Johan Danielsson
ef6c5d89d3 nuke extra definitions of krb5_read_priv_message et.al 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8735 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-21 23:08:06 +00:00
Assar Westerlund
dd770bed63 don't care what principal we recvauth as 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8728 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-21 01:53:36 +00:00
Assar Westerlund
b32eab5560 add --keytab 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8715 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-20 06:53:42 +00:00
Johan Danielsson
aa558f46f1 add realm override flag 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8406 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-06-19 15:47:10 +00:00
Assar Westerlund
b70a38c1c6 (dump_krb4): get expiration date from valid_end' and not pw_end' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7998 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-03-03 12:37:06 +00:00
Assar Westerlund
4b99cbe709 (dump_krb4): use `krb5_get_default_realms' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7741 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-01-06 21:39:24 +00:00
Assar Westerlund
16bf8173da (dump_krb4): kludge default_realm 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7057 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-28 15:55:48 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at} 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-16 21:39:11 +00:00
Assar Westerlund
1a23618348 (main): remove bogus error with `--print'. remove sysloging of number 
of principals transferred


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6948 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-13 01:22:55 +00:00
Assar Westerlund
9382b8a236 add inetd flag. default means try to figure out if stdin is a socket 
or not.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6799 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-12 17:15:37 +00:00
Assar Westerlund
bff061de49 (dump_krb4): check the realm so that we don't dump principals in some 
other realm. From Miroslav Ruda <ruda@ics.muni.cz>
(main): rename sa_len -> sin_len, sa_lan is a define on some
platforms.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6721 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-04 17:10:57 +00:00
Assar Westerlund
90cfa0924e v6-ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6682 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-02 22:14:39 +00:00
Assar Westerlund
e8bb8e29b2 clean-up and re-organize 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6482 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-07-22 09:08:53 +00:00
Assar Westerlund
3e09b67416 support for dumping to krb4. From Miroslav Ruda <ruda@ics.muni.cz> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6228 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-13 23:33:13 +00:00
Johan Danielsson
c99318a862 add --print option 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6105 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-03 17:20:43 +00:00
Assar Westerlund
fc437b9e14 (open_socket): stupid cast to get rid of a warning 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5984 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-04-19 10:23:52 +00:00
Assar Westerlund
7fec939048 fix some error messages to be more understandable. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5873 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-04-07 19:38:29 +00:00
Johan Danielsson
64d4aa49d8 use print_version 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5478 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-08 10:51:48 +00:00