Commit Graph

7 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
d7dd4ad99a Add -Wstrict-overflow=5 as an example.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22901 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-07 19:04:23 +00:00
Love Hörnquist Åstrand
4804d48986 Add --enable-developer and make it cause -Werror to be included.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21183 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-20 03:07:07 +00:00
Love Hörnquist Åstrand
f32ed23aa8 overquote to pacify automake1.8
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13338 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-02-12 14:21:14 +00:00
Johan Danielsson
618e35c0b3 no-return-type -> no-implicit-int
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5496 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-03-11 12:11:41 +00:00
Johan Danielsson
3cd8ad3c04 remove -Wno-return-type from WFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5495 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-03-11 11:07:22 +00:00
Johan Danielsson
e5f97cf0de AC_WFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5487 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-03-10 18:29:19 +00:00