Commit Graph

38 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
54fc57ccb5 s/des_read_pw_string/UI_UTIL_read_pw_string/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12753 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 09:37:03 +00:00
Love Hörnquist Åstrand
0cb8221dda remove \n from errx, from NetBSD
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11666 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-02-25 10:55:17 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Johan Danielsson
3ca5f8150f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 16:58:55 +00:00
Assar Westerlund
bf75fac82a large strc{py,at}_truncate -> strlc{py,at} replacement
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6984 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-16 20:41:57 +00:00
Assar Westerlund
af33e49582 (verify_user_otp): check return value from des_read_pw_string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6964 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-14 21:44:39 +00:00
Johan Danielsson
5f6d5c8c09 use getarg
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5817 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-04-01 14:53:10 +00:00
Johan Danielsson
a5f54865d4 merge strcpy_truncate branch
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5027 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-06-09 19:25:40 +00:00
Assar Westerlund
1d0e156eef (renew): don't set the OTP if the reading of the string fails.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4198 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-12-14 23:57:57 +00:00
Assar Westerlund
7799fc532f List lock-time with `-l'.
New option `-o' to open an locked entry.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1930 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-06-27 13:32:55 +00:00
Assar Westerlund
dd02a92a8b replace sprintf all over the place
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1635 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-05-02 14:29:33 +00:00
Johan Danielsson
e1282e7dfc Update copyright strings.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1541 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-04-01 08:19:18 +00:00
Assar Westerlund
70cea0ce07 more fixes
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1529 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-03-30 17:45:33 +00:00
Assar Westerlund
49d054610e start using err & c:o
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1526 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-03-30 16:52:32 +00:00
Assar Westerlund
d25630601b removed bad free of global data
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1499 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-03-26 23:09:57 +00:00
Assar Westerlund
825ffde8be (renew): return correct status
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1479 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-03-23 05:03:10 +00:00
Assar Westerlund
a502e7b9b7 More fixed from Fabien COELHO <coelho@cri.ensmp.fr>. Check for
current OTP before allowing the update.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1251 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-02-20 19:17:06 +00:00
Assar Westerlund
cf789aab67 updated help string
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1249 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-02-19 19:54:11 +00:00
Assar Westerlund
f2e7484e2a New options -d' and -r'. From Fabien COELHO <coelho@cri.ensmp.fr>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1239 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-02-15 12:38:32 +00:00
Assar Westerlund
b97cdbffff merged in geteuid-fix
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1233 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-02-13 22:34:24 +00:00
Assar Westerlund
b5b1fe5ccf Add `-u' option
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1231 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-02-13 00:04:40 +00:00
Assar Westerlund
6ca646d91a use strlwr
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1096 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-12-14 20:54:52 +00:00
Assar Westerlund
9b4664e29e Use k_getpw{name,uid} and strtok_r
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1051 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-19 04:16:50 +00:00
Assar Westerlund
7f970e5a27 `-s' is now default.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1029 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 16:18:47 +00:00
Assar Westerlund
3b62a43ec6 removed count
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1028 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 16:09:12 +00:00
Assar Westerlund
467c862f2b Check for out of memory.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1009 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 04:41:53 +00:00
Assar Westerlund
dbca8c313e updated options and usage
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1004 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 04:14:12 +00:00
Assar Westerlund
3ae9bbe8c1 fix
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@1000 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 02:28:17 +00:00
Assar Westerlund
ef51fd2aab Use OTP_ALG_DEFAULT.
Consistent language
Check return value from des_read_pw_string.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@999 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-17 02:22:06 +00:00
Assar Westerlund
f5e546a6ff removed print-functionality.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@956 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-14 03:22:03 +00:00
Assar Westerlund
9cedf877b5 Add option `-e' for printing responses in extended mode (according to
draft-ietf-otp-ext-01.txt).


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@922 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-11-02 15:28:34 +00:00
Assar Westerlund
b5852d51fe less warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@908 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-27 23:52:16 +00:00
Johan Danielsson
fec9e52d71 Fix copyright
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@901 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-27 16:50:18 +00:00
Björn Groenvall
3e317bb818 Fix copyright.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@893 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-26 16:05:04 +00:00
Assar Westerlund
cc2014c8c7 new files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@885 ec53bebd-3082-4978-b11e-865c3cabbd6b
1996-10-25 05:51:14 +00:00