Commit Graph

75 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hörnquist Åstrand
d9b05d873f use constants for cache types
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25037 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:03:18 +00:00
Love Hörnquist Åstrand
b5cf4f141d use krb5_cc_new_unique()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25034 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:46 +00:00
Love Hörnquist Åstrand
c8c291d32f drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24498 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:54 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Johan Danielsson
70820d395c log successful logins
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16498 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-09 16:26:25 +00:00
Love Hörnquist Åstrand
9dccedb6d3 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16216 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 13:15:43 +00:00
Love Hörnquist Åstrand
9db7cfbc36 (do_login): only do krb4_get_afs_tokens if we have done v4
authentication or done a 5to4 conversion of tickets. This is to avoid
delays on a realm that only support Kerberos 5 and drop Kerberos 4
requests.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15839 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-08 12:31:57 +00:00
Love Hörnquist Åstrand
958160a533 Include <crypt.h>.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15120 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-11 07:35:04 +00:00
Johan Danielsson
4d41fe5c72 read limits.conf (from /etc/security by default, overridable in
login.conf)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14887 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-22 15:38:33 +00:00
Johan Danielsson
03bae875ad use krb5_appdefault_boolean instead of krb5_config_get_bool
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14203 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-08 09:02:59 +00:00
Johan Danielsson
26457b7135 replace krb5_free_creds_contents by krb5_free_cred_contents
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13790 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-04-25 19:25:35 +00:00
Love Hörnquist Åstrand
1ce5a9d550 (krb5_to4): set client princ of the mcred
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12743 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 00:58:08 +00:00
Love Hörnquist Åstrand
e00dc96279 (krb5_to4): use krb5_cc_clear_mcred
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12424 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-07-06 23:31:49 +00:00
Johan Danielsson
c771f745ac allow "welcome" as well as "motd" in login.conf
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11903 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-03-24 15:57:10 +00:00
Love Hörnquist Åstrand
8dd6b56464 also need pag_set
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11865 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-03-18 14:07:15 +00:00
Love Hörnquist Åstrand
b42c3b6db9 if there is kerberos 5, call krb5_afslog\*
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11864 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-03-18 14:01:05 +00:00
Johan Danielsson
6319705d6c if motd is set in login.conf, output its contents before starting the
shell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11217 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-08-23 12:11:09 +00:00
Johan Danielsson
7866d0681c foo
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10861 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-03-01 10:38:06 +00:00
Johan Danielsson
6b6d122805 reset signals to default, needed on solaris 8
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10855 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-02-27 10:51:27 +00:00
Johan Danielsson
6a4833e568 make this build without krb5
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10849 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-02-19 09:35:23 +00:00
Assar Westerlund
d04182e5c4 (do_login): add setpcred
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10714 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-17 02:34:31 +00:00
Assar Westerlund
9b773c4a8f move osf2c magic earlier. from Mark Davies <mark@MCS.VUW.AC.NZ>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10288 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-07-06 17:36:48 +00:00
Assar Westerlund
bd4ea7853d (krb5_to4): dereference result from krb5_princ_realm. noted by Thomas
Nystrom <thn@saeab.se>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10123 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-19 09:01:36 +00:00
Assar Westerlund
99f53c4c8b new krb524_convert_creds_kdc_ccache
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10113 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-18 13:11:33 +00:00
Assar Westerlund
0e5b21d56f (krb5_to4): look for [realms]<realm>krb4_get_tickets to decide whether
to get kerberos 4 tickets


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10018 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-05-31 15:25:59 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Assar Westerlund
d4413a1b09 remove some krb5_free_context that might happen at unappropriate times
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9563 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-01-29 02:18:03 +00:00
Assar Westerlund
633782864b (main): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9443 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 08:05:03 +00:00
Assar Westerlund
f16bfac946 (do_login): set the group on the tty.
(r_flag): comment out


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9346 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-11 00:25:01 +00:00
Assar Westerlund
f628d2de7d (krb5_to4): always return a value
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9345 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-11 00:23:31 +00:00
Assar Westerlund
abeb3155e2 (krb5_to4): check another return code
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9119 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-10-14 23:31:41 +00:00
Assar Westerlund
3e00ddf50d use esetenv
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9089 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-10-02 05:06:04 +00:00
Assar Westerlund
7ce8ee6f99 (krb5_verify): remove bogus extra code
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9060 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-09-19 11:55:28 +00:00
Johan Danielsson
0c95f3d5dc (do_login): set PATH to something sane;
(start_logout_process): avoid getting signals sent to the parent


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8985 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-08-22 14:07:44 +00:00
Assar Westerlund
9779ecd1bf (login_timeout): add back
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8501 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-01 14:12:44 +00:00
Johan Danielsson
0336129055 move environment stuff to separate file, allow specifying list of
environment files via login.conf


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8475 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-28 12:26:56 +00:00
Assar Westerlund
9312ada187 add reading of /etc/environment. From Ake Sandgren <ake@cs.umu.se>
add otp support. From Daniel Kouril <kouril@ics.muni.cz>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8422 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-21 02:08:56 +00:00
Assar Westerlund
8e08fa51b0 (do_login): work-around for setuid and capabilities bug fixed in Linux
2.2.16


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8366 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-09 10:06:38 +00:00
Assar Westerlund
51675c657f allow conversion of v5 -> v4 tickets when logging in with forwarded
tickets


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8159 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-04-09 11:17:22 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Assar Westerlund
7a36ab6daf (do_login): conditionalize shadow stuff on getspnam
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7320 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-11-05 08:14:56 +00:00
Assar Westerlund
e1c9455af4 (start_logout_proceess): don't examine `prog' before setting it.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7262 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-28 19:12:35 +00:00
Assar Westerlund
3a9217cf73 (do_login): chown and chmod the tty. some clean-up.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7241 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-27 21:34:29 +00:00
Assar Westerlund
d558aae384 (krb5_start_session): correct the ccache to krb524_convert_creds_kdc
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7092 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-03 19:53:32 +00:00
Assar Westerlund
a5ea5cf66d (krb5_verify): use krb5_verify_user_lrealm
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7050 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-28 02:34:17 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at}
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-16 21:39:11 +00:00
Johan Danielsson
09bf3fa023 SGI capability mumbo-jumbo
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6892 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-01 11:03:23 +00:00