Commit Graph

22 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
177122d8b9 use krb5_get_error_message for logging 2011-03-12 13:23:07 -08:00
Love Hornquist Astrand
2127d8d6bc free auth_context on close [CID-98] 2009-07-30 11:19:15 +02:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
5118c90498 Rename u_intXX_t to uintXX_t
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17450 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-05-05 11:11:43 +00:00
Love Hörnquist Åstrand
3a4c95a266 krb5_encrypt now takes a const, no need for casting
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15605 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 12:41:37 +00:00
Love Hörnquist Åstrand
5e969ca2b3 fix unconst and shadow warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15600 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-07-09 02:19:10 +00:00
Love Hörnquist Åstrand
a4cd8b41d9 cast size_t to unsigned long
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14862 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-20 10:39:33 +00:00
Love Hörnquist Åstrand
1aedcbce16 (krb5_destroy): free allocated memory, not something else
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13530 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-15 18:19:01 +00:00
Love Hörnquist Åstrand
4471b21263 clean up krb5 support, log to syslog instead of stdout (very confusing
for the other end tcp connection), patch originally from joda


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13260 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-01-08 10:03:19 +00:00
Johan Danielsson
8507a7a1d2 (krb5_authenticate): use subkey
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11402 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-09 13:14:58 +00:00
Johan Danielsson
5eddbd04db add missing semi in previous
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11020 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-05-24 15:13:52 +00:00
Johan Danielsson
a51951c17a use krb5_warn where appropriate
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10969 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-05-07 08:53:36 +00:00
Assar Westerlund
a8b6f76c6d (krb5_make_context): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9428 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 07:32:03 +00:00
Assar Westerlund
2f2114fbf0 (krb5_copy_encrypted): check that fds are not too large to select on
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9099 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-10-08 13:20:12 +00:00
Assar Westerlund
9784176873 (krb5_kuserok): type correctness
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7512 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-04 23:06:18 +00:00
Johan Danielsson
3ca5f8150f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 16:58:55 +00:00
Assar Westerlund
506da8874a (krb5_destroy): free the correct part of the context
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7413 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-11-18 12:46:04 +00:00
Assar Westerlund
ed2ea45a18 comments
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6215 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-12 17:46:55 +00:00
Assar Westerlund
0d3484018a new files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6184 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-10 00:20:16 +00:00