oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
27,084 Commits 2 Branches 2 Tags
cc47c8fa7b0f4567bb9dd7e692c32a558a166d5c
Commit Graph

35 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Nicolas Williams
40a7d4b62f More fixes for -Werror (GCC 4.6 catches more stuff) 2011-11-02 23:20:55 -05:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
aa750c33d1 remove unused variables 2010-11-20 14:13:58 -08:00
Love Hornquist Astrand
65a1ee8163 dont use private prototype 2010-11-20 14:13:31 -08:00
Asanka Herath
d00f9984a5 Make roken build on windows 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2009-11-24 21:42:02 -08:00
Love Hörnquist Åstrand
428949990f uniquify error messages 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24782 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:26:07 +00:00
Love Hörnquist Åstrand
aa64f90c1c implement UnwrapExt 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24781 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:25:57 +00:00
Love Hörnquist Åstrand
d44779d9d0 make compile 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24778 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:25:28 +00:00
Love Hörnquist Åstrand
d5f371960e use WRAP_EXP_ONLY_HEADER 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24776 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:25:01 +00:00
Love Hörnquist Åstrand
dc3e6ad589 change seqno to bflag to allow testing dce style 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24775 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:24:49 +00:00
Love Hörnquist Åstrand
5089b9c84b Code to handle WrapExt 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24770 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-02-22 23:23:55 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
832a72e67b Use unsigned where appropriate. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22887 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-04-07 18:51:38 +00:00
Love Hörnquist Åstrand
e270dfd78e (AcquirePKInitCreds): fail more gracefully 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21229 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-06-20 10:19:19 +00:00
Love Hörnquist Åstrand
ece5f9603e Make krb5_get_init_creds_opt_free take a context argument. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19078 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-11-20 18:12:41 +00:00
Love Hörnquist Åstrand
32df330c53 Only log when there are resources left. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18891 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-24 23:30:56 +00:00
Love Hörnquist Åstrand
653bb59432 Try free all resources. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18890 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-24 23:29:34 +00:00
Love Hörnquist Åstrand
cb603a5624 Avoid leaking memory. rename ->handle to ->handles. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18887 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-24 22:35:53 +00:00
Love Hörnquist Åstrand
ef5a0a83f1 make compile 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18880 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-24 21:01:40 +00:00
Love Hörnquist Åstrand
a79baec2e3 (AcquireCreds): free krb5_get_init_creds_opt 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18879 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-24 20:16:29 +00:00
Love Hörnquist Åstrand
bcf5576db0 handle more bits 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18493 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-10-17 03:08:22 +00:00
Love Hörnquist Åstrand
77a889cd29 Don't announce spn if there is non. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18175 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-25 23:33:54 +00:00
Love Hörnquist Åstrand
58de1f16ce Fix logging. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18164 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-25 16:28:40 +00:00
Love Hörnquist Åstrand
d8bc0ea463 Add mic tests 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18141 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-21 09:57:26 +00:00
Love Hörnquist Åstrand
6f5411adfa Add wrap/unwrap ops 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18130 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-20 12:16:15 +00:00
Love Hörnquist Åstrand
e8d7e48ab5 use new flags, return moniker 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18124 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-20 03:31:50 +00:00
Love Hörnquist Åstrand
c1e7cda8e8 add --logfile option, use htons() on port number 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18115 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-09-19 10:20:50 +00:00
Love Hörnquist Åstrand
0822bf8ae4 use utname() to find the local hostname 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17796 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-07-03 10:52:05 +00:00
Love Hörnquist Åstrand
fffc248c1f break out creation of a client and make handleServer pthread_create compatible 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17793 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-07-02 22:36:37 +00:00
Love Hörnquist Åstrand
f409403b7d AcquireCreds: set principal to NULL to avoid memory corruption 
GetTargetName: always send a string, even though we don't have a targetname


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17786 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-07-01 09:28:42 +00:00
Love Hörnquist Åstrand
88c076e738 break out common function; add gssmaestro (that only tests one context for now) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17780 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-07-01 08:44:30 +00:00
Love Hörnquist Åstrand
1a7f7f4e24 split out fetching of credentials for easier reuse for pk-init testing 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17772 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-06-30 20:21:24 +00:00
Love Hörnquist Åstrand
cbad9c5477 gssapi maggot replacement, handles context testing 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17771 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-06-30 20:05:42 +00:00