Commit Graph

80 Commits

Author SHA1 Message Date
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hörnquist Åstrand 4c639408e6 drop krb4 2011-08-10 09:27:48 -07:00
Love Hörnquist Åstrand 7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hornquist Astrand 0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner 97df66c0a0 Put Nd argument after Nd macro.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:27 -07:00
Love Hornquist Astrand c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand 27b314c4e7 %o is unsigned int, case appropriately 2009-08-14 11:17:44 +02:00
Love Hörnquist Åstrand 1e5a14f8bd use S_ISDIR and S_ISREG
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25229 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-25 23:44:52 +00:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand 85c940fa73 Sync with NetBSD rcp, add v6 parsing support and no setuid code at all.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23028 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-04-17 17:30:06 +00:00
Love Hörnquist Åstrand 6855b33640 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22282 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-13 20:36:12 +00:00
Love Hörnquist Åstrand c2fcf3f57d Add missing files, from Buchan Milne.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22281 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-12-13 20:35:52 +00:00
Love Hörnquist Åstrand cc4333b758 remove cvs ignore files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-09 03:09:59 +00:00
Love Hörnquist Åstrand 083bc44bdc x
x


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18826 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-22 15:52:52 +00:00
Love Hörnquist Åstrand d8fb637ef8 more files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18663 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-20 17:09:30 +00:00
Love Hörnquist Åstrand ce572a7ba7 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18662 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-10-20 17:01:34 +00:00
Love Hörnquist Åstrand 847a99a0ec Check return values from setuid, prompted by MIT
advisory.  Thanks to Tom Yu at MIT, and Michael Calmer and Marcus
Meissner at SUSE.  Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17878 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-08-08 21:43:58 +00:00
Love Hörnquist Åstrand fd6204f302 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17875 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-08-08 21:09:34 +00:00
Love Hörnquist Åstrand f1e2dae0f6 Check return values from seteuid, prompted by MIT advisory.
Thanks to Tom Yu at MIT, and Michael Calmer and Marcus Meissner at SUSE.
Either of CVE-2006-3083 or CVE-2006-3084.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17874 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-08-08 21:08:46 +00:00
Love Hörnquist Åstrand 4232beb6e4 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16219 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 14:19:01 +00:00
Love Hörnquist Åstrand e5dc0153d3 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16218 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 14:18:19 +00:00
Love Hörnquist Åstrand 785481e6e5 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16000 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-30 09:31:37 +00:00
Love Hörnquist Åstrand be47b11f0a Explicit typecast to avoid signess warning.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15999 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-30 09:31:17 +00:00
Love Hörnquist Åstrand 7b953d1fc7 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15286 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-29 18:24:53 +00:00
Love Hörnquist Åstrand 0762e9fb19 undef _PATH_RSH to make sure our version is used
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15285 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-29 18:24:43 +00:00
Love Hörnquist Åstrand 60ed51e6da MODEMASK is defined in sys/vnode.h on Solaris, so undef it before we
define our own.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15123 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-11 11:04:30 +00:00
Love Hörnquist Åstrand 222ad8ddba x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14996 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-27 19:21:28 +00:00
Love Hörnquist Åstrand 86d1dc0dc6 use BINDIR instead of "/usr/bin/ with _PATH_RSH
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14995 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-27 19:20:22 +00:00
Love Hörnquist Åstrand 2cc85f5d17 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14817 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-18 07:54:00 +00:00
Love Hörnquist Åstrand 5c338794d7 use unsigned char * to make sure its not negative when passing it to
is* functions


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14816 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-04-18 07:52:58 +00:00
Johan Danielsson 0624b4457e replace INCLUDES with AM_CPPFLAGS
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14164 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-26 11:55:29 +00:00
Johan Danielsson e2fafb475a x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13850 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-05-14 14:33:49 +00:00
Johan Danielsson 558712f71f add -e (passed to rsh)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13849 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-05-14 14:33:42 +00:00
Johan Danielsson 88d22cc116 x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12026 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-16 12:22:08 +00:00
Johan Danielsson 0b3cdea4c8 add a HISTORY section
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12025 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-16 12:20:43 +00:00
Johan Danielsson 9a3904e694 brief manpage
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12024 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-16 12:17:27 +00:00
Johan Danielsson 6ecd034eaf add a -4 option
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12023 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-16 12:14:45 +00:00
Johan Danielsson 680399419e x
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10740 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-24 12:20:07 +00:00
Johan Danielsson c884ea3911 more va_* fixing; from Thomas Klausner
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10738 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-24 12:14:12 +00:00
Assar Westerlund 39ecec8e5a *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10673 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-08 01:54:19 +00:00
Assar Westerlund 3fbcb739f8 (run_err): always match va_start and va_end
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10672 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-08 01:53:37 +00:00
Assar Westerlund dcefdf58ae *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10658 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-04 14:36:07 +00:00
Assar Westerlund e706d29cca (allocbuf): do not leak memory on failure and zero re-used memory,
from Markus Friedl <markus@openbsd.org>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10657 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-04 14:35:58 +00:00
Assar Westerlund 897f0b1f93 unsigned char casts for is*, casts for socket functi, add headers
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10646 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-03 05:54:18 +00:00
Assar Westerlund 3b2bba8c9a *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10351 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-07-19 13:57:47 +00:00
Assar Westerlund 95b8dde3e4 (main): add missing setprogname
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10350 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-07-19 13:57:36 +00:00
Assar Westerlund aff958384d *** empty log message ***
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10048 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-16 20:59:42 +00:00
Assar Westerlund 81ed451753 some cleanup
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10047 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-14 20:30:25 +00:00
Assar Westerlund 8ced53f487 add some const
replace a few malloc/snprintf with asprintf


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10046 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-14 20:28:34 +00:00