Commit Graph

51 Commits

Author SHA1 Message Date
Jelmer Vernooij 70e43e9808 Fix some typos. 2014-04-25 02:42:17 +02:00
Roland C. Dowdeswell e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Nicolas Williams 265d9ba5ca Error/warning cleanups for clang (LLVM) 2011-11-28 14:42:06 -06:00
Love Hornquist Astrand 0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand 3f3b499c39 NULL_RETURNS paranoid check [CID-66] 2009-07-30 07:50:18 +02:00
Love Hörnquist Åstrand 68b804787c use krb5_cc_new_unique, use constants for cache types
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25040 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:03:50 +00:00
Love Hörnquist Åstrand e0229329fd use krb5_cc_new_unique, use constants for cache types
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25039 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:03:39 +00:00
Love Hörnquist Åstrand a5e6d1338b catch error and, while here, destroy credential caches on error
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24866 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-27 03:32:31 +00:00
Love Hörnquist Åstrand 10916974df Remove unsed variable kerberos_error.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24864 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-27 03:32:00 +00:00
Love Hörnquist Åstrand 3ad1d78d63 make roken not provide environ, its really something that doesnt work in a multinamespace enviroments (read mac os x)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23943 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-19 04:57:42 +00:00
Love Hörnquist Åstrand ab68b1d64f spelling
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23890 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-10-13 03:00:24 +00:00
Love Hörnquist Åstrand 6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand 1e2c257600 Drop kerberos 4 support.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23363 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-07-15 11:25:29 +00:00
Love Hörnquist Åstrand fa7b8061d9 read environment from _PATH_ETC_ENVIRONMENT
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21988 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-10-19 05:36:54 +00:00
Love Hörnquist Åstrand 323dfbeabf Check all local realms when su-ing, from Magnus Holmberg.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21789 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-08-02 17:32:44 +00:00
Love Hörnquist Åstrand f2822370c3 If not root and not setuid, print warning.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21179 ec53bebd-3082-4978-b11e-865c3cabbd6b
2007-06-19 15:16:41 +00:00
Love Hörnquist Åstrand 3fcd74bc9b (group_member_p): rename from group_member to avoid name pollution
from glibc headers.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16576 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-17 15:38:18 +00:00
Johan Danielsson b126bb0e5b (verify_unix): if su:ing to root, check that user is a member of group
"wheel"


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16527 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-12 16:24:28 +00:00
Johan Danielsson 62018203ff fix reversed logic when deciding to print tty or not
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16525 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-01-12 15:16:55 +00:00
Love Hörnquist Åstrand 4863ea9553 Check return value from asprintf instead of string != NULL since it
undefined behavior on Linux. From Björn Sandell


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16220 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-10-22 15:07:48 +00:00
Love Hörnquist Åstrand 958160a533 Include <crypt.h>.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15120 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-05-11 07:35:04 +00:00
Love Hörnquist Åstrand 54fc57ccb5 s/des_read_pw_string/UI_UTIL_read_pw_string/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12753 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 09:37:03 +00:00
Johan Danielsson 6bbb1400f8 remove accidentally committed code that prints the command being
executed


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12213 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-05-06 12:05:38 +00:00
Love Hörnquist Åstrand 451649f07e (krb5_start_session): krb5_afslog doesn't depend on KRB4 any more
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11857 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-03-18 13:34:26 +00:00
Johan Danielsson 77de2f4011 use crypto-headers.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11444 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-09-10 20:03:49 +00:00
Johan Danielsson e9df0a5333 make this build without krb5
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10852 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-02-19 13:01:15 +00:00
Jacques A. Vidrine a574aa640b Don't use getlogin() to determine whether we are root.
Patch by joda.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10808 ec53bebd-3082-4978-b11e-865c3cabbd6b
2002-01-09 19:43:19 +00:00
Assar Westerlund 556bb889fb new style of using crypto libraries
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10521 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-08-22 20:35:38 +00:00
Assar Westerlund 3be52e80f2 check memory allocations. add some const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10042 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-06-12 12:30:44 +00:00
Assar Westerlund 67422a6b02 s/[gs]et_progname/[gs]etprogname/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-20 01:44:56 +00:00
Assar Westerlund 2aefcf796c try to use handle using openssl instead of libdes better. based on patches from GOMBAS Gabor <gombasg@inf.elte.hu> and Brian May <bam@snoopy.apana.org.au>
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9681 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-02-15 04:20:54 +00:00
Johan Danielsson 4b0a1e40e1 snprintf
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9509 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-01-26 16:02:49 +00:00
Assar Westerlund 010888a340 (krb5_verify): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9431 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 07:38:37 +00:00
Assar Westerlund 3e00ddf50d use esetenv
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9089 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-10-02 05:06:04 +00:00
Johan Danielsson ad8e719ef7 set KRBTKFILE
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9016 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-08-28 12:12:28 +00:00
Assar Westerlund c0b819a8aa (krb5_verify): try harder freeing. do not get upset on interrupted
password read


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8634 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-10 02:10:30 +00:00
Assar Westerlund b494b7cebb (main): work-around for setuid and capabilities bug fixed in Linux
2.2.16


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8367 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-09 10:08:30 +00:00
Assar Westerlund 62cd158440 (main): just ignore shadow information if getspnam returns NULL
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8310 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-03 12:58:28 +00:00
Assar Westerlund d37d58a21c add des.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8303 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-05-29 16:53:29 +00:00
Assar Westerlund a5ea5cf66d (krb5_verify): use krb5_verify_user_lrealm
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7050 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-28 02:34:17 +00:00
Assar Westerlund 29e402a549 ifdef KRB4
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6735 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-04 19:50:03 +00:00
Assar Westerlund 55c9485f34 add support for shadow passwords and rewrite some logic. From
Miroslav Ruda <ruda@ics.muni.cz>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6718 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-04 17:05:46 +00:00
Assar Westerlund 754f056849 (main): conditionalize `getlogin'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6312 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-06-15 02:45:03 +00:00
Assar Westerlund 74f6a0d445 (verfiy_krb5): get the name out of the ccache before closing it
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6206 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-11 13:16:07 +00:00
Assar Westerlund 090a6120a5 some more error checking
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6139 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-05 01:27:23 +00:00
Assar Westerlund 390a7590fe (-f): implement
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6024 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-04-21 09:16:12 +00:00
Assar Westerlund d4cac3fd86 implement -i
(verify_krb5): correct the ownership on the credential cache


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6023 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-04-21 09:04:32 +00:00
Johan Danielsson 55f24fcc4b don't depend on paths.h
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6015 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-04-20 11:25:46 +00:00