oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
30,873 Commits 2 Branches 2 Tags
ba8c3dbc6261ab397ce5bb4fc0ca6b0ea23eb46a
Commit Graph

40 Commits

Author SHA1 Message Date
Jeffrey Altman
800515b033 lib/krb5: akf_add_entry do not leak 'fd' 
5be5faa722
("Use all DES keys, not just des-cbc-md5, verify that they all are the same.")
introduced a common out but missed a code path.

Change-Id: I27c1913c8cf87600ae34c42874bfc9d49ae1d22e
 2022-01-16 18:08:50 -05:00
Nicolas Williams
1c81ddf4e2 Round #2 of scan-build warnings cleanup 2016-11-16 17:03:14 -06:00
Roland C. Dowdeswell
f0f07ff408 Use krb5_enomem() more consistently in lib/krb5. 2013-02-13 16:15:00 +08:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
e5ce363778 list both des-cbc-crc and des-cbc-md5 entries 2011-08-31 09:13:37 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Asanka Herath
5dcc605f6b Fix calling conventions for Windows 2010-08-20 13:14:10 -04:00
Love Hörnquist Åstrand
942a821fab remove RCSID 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25171 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-05-04 06:17:40 +00:00
Love Hörnquist Åstrand
10336e8213 set flags and aliases 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24458 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:47:22 +00:00
Love Hörnquist Åstrand
8de5319396 add destroy 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24436 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-25 00:43:46 +00:00
Love Hörnquist Åstrand
1dae446485 no AFSKEYFILE in small libraries 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23969 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-26 18:23:00 +00:00
Love Hörnquist Åstrand
03babea1e3 switch to krb5_clear_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23911 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-10-14 02:55:39 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
eb589b6dbb N_()ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23784 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-07 21:26:53 +00:00
Love Hörnquist Åstrand
7b5981996c sprinle O_CLOEXEC, from Andrew Bartlett 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23474 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-07-28 08:49:43 +00:00
Love Hörnquist Åstrand
7fcd266fdd use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23316 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 04:32:32 +00:00
Love Hörnquist Åstrand
7339c60031 use krb5_set_error_message 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23291 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-06-23 03:28:00 +00:00
Love Hörnquist Åstrand
156b2c77e8 Make num_entries an uint32 to avoid negative numbers and type warnings. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22986 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-04-15 15:55:01 +00:00
Love Hörnquist Åstrand
34faa9fe6e better error strings for the keytab fetching functions 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22532 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-01-27 11:59:18 +00:00
Love Hörnquist Åstrand
fa4a82327c Spelling. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20695 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2007-05-30 14:09:09 +00:00
Love Hörnquist Åstrand
4ba57d49e9 (get_cell_and_realm): reset d->cell to make sure its not refereced 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17213 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-24 15:06:57 +00:00
Love Hörnquist Åstrand
4fd7055bdf (get_cell_and_realm): plug a memory leak, found by IBM checker. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16942 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2006-04-02 01:24:52 +00:00
Love Hörnquist Åstrand
5be5faa722 Use all DES keys, not just des-cbc-md5, verify that they all are the same. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@16110 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-09-30 11:20:53 +00:00
Love Hörnquist Åstrand
5f77418366 cast argument to toupper to unsigned char 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14496 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-01-08 22:57:18 +00:00
Johan Danielsson
27cc22110f more strcspn 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11513 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-10-21 15:42:06 +00:00
Jacques A. Vidrine
5e6f1d8e82 Use O_EXCL when creating a new keyfile. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11414 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-09-09 14:22:26 +00:00
Johan Danielsson
6cd4200dd5 storage tweaks 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10934 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-04-18 14:04:46 +00:00
Johan Danielsson
f5fea2deb2 (akf_add_entry): don't create the file before we need to write to it 
(from Åke Sandgren)


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10838 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2002-02-15 14:32:52 +00:00
Assar Westerlund
d27aa3b62e add some krb5_{set,clear}_error_string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9937 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-14 06:14:52 +00:00
Johan Danielsson
548fd18bcc (akf_start_seq_get): return KT_NOTFOUND if the file is empty 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9857 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-05-07 19:41:41 +00:00
Assar Westerlund
664ffd49ab (akf_add_entry): remove unused variable 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8537 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-07-02 16:14:16 +00:00
Johan Danielsson
be412389eb make this actually work 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8289 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-05-23 15:00:27 +00:00
Assar Westerlund
de504c0786 (akf_next_entry): remove unused variable 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7709 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-01-02 04:00:22 +00:00
Assar Westerlund
32a12060f5 (akf_next_entry): set timetsamp, always go the a predicatble position 
on error


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7702 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-01-02 00:45:38 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 17:05:13 +00:00
Johan Danielsson
5766d52355 make krb5_akf_ops const 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7074 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-10-03 14:46:57 +00:00
Assar Westerlund
d3f5d79294 strc{py,at}_truncate -> strlc{py,at} 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6985 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-16 21:39:11 +00:00
Assar Westerlund
d66db0b648 (get_cell_and_realm): only remove the newline if it's there 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6962 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-14 15:42:45 +00:00
Assar Westerlund
21eec7e0bc new file 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6940 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-09-12 20:48:50 +00:00