oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity
28,243 Commits 2 Branches 2 Tags
b77e701a22991b79c6a76b1cfeeb7cd19991d01a
Commit Graph

58 Commits

Author SHA1 Message Date
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues. 
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
 2012-02-20 19:45:41 +00:00
Nicolas Williams
3bebbe5323 Fixes to make Heimdal -Wall -Werror clean 
These fixes make developer mode build, at least on Ubuntu.
 2011-11-02 21:42:08 -05:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Anton Lundin
057f139f6a Fix to build on aix. 
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
 2010-09-17 12:21:58 -07:00
Love Hörnquist Åstrand
9ac56d0e57 drop krbv4 support 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24503 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2009-01-26 01:10:59 +00:00
Love Hörnquist Åstrand
46d54811be init count before use, coverity #150 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24096 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-12-11 04:58:58 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
c72b9bb2b9 Use unsigned where appropriate. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22888 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2008-04-07 18:51:49 +00:00
Love Hörnquist Åstrand
e19f9f0e6c catch when snprint needs a larger buffer 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14850 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2005-04-19 18:00:17 +00:00
Johan Danielsson
586752552d alloc memory to handle very long lines 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13937 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2004-06-17 14:03:35 +00:00
Assar Westerlund
f64b6ae0cc fixed one incorrect fprintf to stderr 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11968 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-04-04 02:10:17 +00:00
Love Hörnquist Åstrand
db5235baa9 add names of pop states, add some more debugging and use 
fprintf(stderr) for all dbg stmts.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11875 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2003-03-18 18:21:28 +00:00
Assar Westerlund
be5fe4842b (doit): check return values from snprintf being negative 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10652 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-09-04 09:45:52 +00:00
Assar Westerlund
67422a6b02 s/[gs]et_progname/[gs]etprogname/ 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9704 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2001-02-20 01:44:56 +00:00
Assar Westerlund
633782864b (main): handle krb5_init_context failure consistently 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9443 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-31 08:05:03 +00:00
Assar Westerlund
76794120ed (doit): move some code to handle non-from case correctly 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9419 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-26 00:24:42 +00:00
Assar Westerlund
6c2a214b37 support several headers, from <mattiasa@e.kth.se> 
use estrdup, emalloc, erealloc


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9416 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-12-25 23:56:16 +00:00
Johan Danielsson
4852c15635 add space to usage 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9217 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-11-27 13:33:04 +00:00
Assar Westerlund
2f271d23fb (doit): check that fds are not too large to select on 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9102 ec53bebd-3082-4978-b11e-865c3cabbd6b
 2000-10-08 13:26:50 +00:00
Assar Westerlund
0e1a79c29e (main): call k_getportbyname with port number in network-byte-order 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7682 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-28 03:46:06 +00:00
Assar Westerlund
501e82d570 (do_connect): remove bogus local block variable 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7596 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-14 14:23:58 +00:00
Assar Westerlund
ad622a77ad (do_connect): use `getaddrinfo' 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7538 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-05 13:06:43 +00:00
Assar Westerlund
f460876c03 add --count (print number of messages and bytes at beginning) 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7535 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-05 13:00:38 +00:00
Johan Danielsson
3ca5f8150f remove advertising clause 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7463 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-12-02 16:58:55 +00:00
Assar Westerlund
c3e67ab7c2 make `-v' a arg_counter 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7361 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-11-13 04:08:12 +00:00
Assar Westerlund
ac5267f34c (main): redo the v4/v5 selection for consistency. 
-4 -> try only v4
-5 -> try only v5
none, -45 -> try v5, v4


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7297 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-11-02 22:45:10 +00:00
Assar Westerlund
5a7f25bfd1 (doit): remember to step over the error message when we discover that 
XDELE is not supported


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6842 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-19 17:26:53 +00:00
Johan Danielsson
79af5ad01f use XDELE 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6797 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-12 11:44:54 +00:00
Assar Westerlund
3b5d22066c (do_connect): v6-ify 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6755 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-08-05 12:21:17 +00:00
Assar Westerlund
20a96cbc2e get_default_username and the resulting const propagation 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6327 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-06-15 04:37:36 +00:00
Assar Westerlund
c9a66968e9 (parse_pobox): try $USERNAME 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6263 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-21 09:24:06 +00:00
Assar Westerlund
d2c7bccc8b (do_v5): remove unused and non-working code 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6207 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-11 13:19:20 +00:00
Assar Westerlund
f546bbcf16 (do_v5): call krb5_sendauth with ccache == NULL 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6193 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-05-10 03:47:40 +00:00
Assar Westerlund
a468b60640 (get_pobox): try to handle old and new hesiod APIs 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5728 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-24 03:37:02 +00:00
Johan Danielsson
ba1f84a42d strncasecmp headers 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5546 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-03-15 17:26:10 +00:00
Assar Westerlund
8343b4ae3f (usage): update usage string 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5452 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-02-27 22:45:40 +00:00
Assar Westerlund
31b022919d (do_connect): init `s' 
(pop_state): spell-check enums


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5371 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1999-02-15 21:22:06 +00:00
Assar Westerlund
d0fd153c88 spelling 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5250 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-11-25 09:41:10 +00:00
Johan Danielsson
893d27f8f2 eliminate some warnings 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5239 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-11-22 14:33:51 +00:00
Assar Westerlund
f6e3624cce (get_pobox): new function. add hesiod support. 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5199 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-11-19 00:16:37 +00:00
Assar Westerlund
4997b65eed --from implementation from <lha@stacken.kth.se> 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5187 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-11-07 14:50:12 +00:00
Assar Westerlund
d26a0c9175 new arg_printusage 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5127 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-08-18 20:49:26 +00:00
Assar Westerlund
df5e4682df (parse_pobox): set f 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5077 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-07-10 01:55:59 +00:00
Assar Westerlund
b546ea105d (net_{read,write}): remove 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5071 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-07-09 23:14:42 +00:00
Johan Danielsson
a3834aa6e6 x 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5035 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-06-29 00:40:03 +00:00
Johan Danielsson
c9e2af3ca3 cleanup pobox parsing 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5033 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-06-29 00:16:34 +00:00
Johan Danielsson
778d4a1c5d allow `po:user@host' mailbox syntax 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5031 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-06-24 18:36:51 +00:00
Johan Danielsson
2f6811fbde quote '^From ' properly 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5013 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-06-02 15:34:57 +00:00
Johan Danielsson
aaba6c3d70 typo 
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4895 ec53bebd-3082-4978-b11e-865c3cabbd6b
 1998-05-18 18:23:05 +00:00