Nicolas Williams 
							
						 
					 
					
						
						
							
						
						5f63215d0d 
					 
					
						
						
							
							Always perform == or != operation on cmp function result  
						
						... 
						
						
						
						Although not required to address bad code generation in
some versions of gcc 9 and 10, a coding style that requires
explicit comparison of the result to zero before use is
both clearer and would have avoided the generation of bad
code.
This change converts all use of cmp function usage from
```
    if (strcmp(a, b) || !strcmp(c, d)) ...
```
to
```
    if (strcmp(a, b) != 0 || strcmp(c, d)) == 0
```
for all C library cmp functions and related:
 - strcmp(), strncmp()
 - strcasecmp(), strncasecmp()
 - stricmp(), strnicmp()
 - memcmp()
Change-Id: Ic60c15e1e3a07e4faaf10648eefe3adae2543188 
						
						
					 
					
						2021-11-24 22:30:44 -05:00 
						 
				 
			
				
					
						
							
							
								Quanah Gibson-Mount 
							
						 
					 
					
						
						
							
						
						7c16ce3457 
					 
					
						
						
							
							Minor typo/grammar fixes  
						
						
						
						
					 
					
						2017-03-10 15:47:43 -05:00 
						 
				 
			
				
					
						
							
							
								Viktor Dukhovni 
							
						 
					 
					
						
						
							
						
						bf40b8cc63 
					 
					
						
						
							
							Comment wordsmithing  
						
						
						
						
					 
					
						2013-05-02 01:31:01 -04:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						7aaba443bc 
					 
					
						
						
							
							add NTMakefile and windows directories  
						
						
						
						
					 
					
						2011-07-17 12:16:59 -07:00 
						 
				 
			
				
					
						
							
							
								Love Hornquist Astrand 
							
						 
					 
					
						
						
							
						
						0879b9831a 
					 
					
						
						
							
							remove trailing whitespace  
						
						
						
						
					 
					
						2011-05-21 11:57:31 -07:00 
						 
				 
			
				
					
						
							
							
								Asanka Herath 
							
						 
					 
					
						
						
							
						
						b1063ea8fc 
					 
					
						
						
							
							Initial Windows port  
						
						
						
						
					 
					
						2009-11-24 10:11:14 -08:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						6937d41a02 
					 
					
						
						
							
							remove trailing whitespace  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2008-09-13 09:21:03 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						e172367898 
					 
					
						
						
							
							switch to utf8 encoding of all files  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2008-09-13 08:53:55 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						a69298f8c8 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22280 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2007-12-13 20:34:54 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						103e7dc783 
					 
					
						
						
							
							Add missing files, from Buchan Milne.  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22279 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2007-12-13 20:34:44 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						5fed824f37 
					 
					
						
						
							
							its vs it\'s etc. From Bjorn Sandell  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@22071 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2007-11-14 20:04:50 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						cc4333b758 
					 
					
						
						
							
							remove cvs ignore files  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@21026 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2007-06-09 03:09:59 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						cd67e721c3 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17877 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2006-08-08 21:31:30 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						b42ab99857 
					 
					
						
						
							
							Check for seteuid failure, prompted by MIT advisory.  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17876 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2006-08-08 21:31:02 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						c41860a8ee 
					 
					
						
						
							
							use NULL as last argument to execl, not 0  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14747 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2005-04-06 11:23:54 +00:00 
						 
				 
			
				
					
						
							
							
								Love Hörnquist Åstrand 
							
						 
					 
					
						
						
							
						
						2697d2a0f3 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14746 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2005-04-06 11:23:17 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						2f3635070b 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11078 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2002-08-12 15:03:49 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						7312ead338 
					 
					
						
						
							
							rename dpagaix_LDFLAGS etc to appease automake  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11077 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2002-08-12 15:03:43 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						cbcdc68e67 
					 
					
						
						
							
							in unused code: pass file mode in call to open(); found by Martin Laubach  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@11067 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2002-08-09 13:19:41 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						8a4563302c 
					 
					
						
						
							
							some spelling from Thomas Klausner  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10793 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-11-22 08:27:55 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						9a9acaf6c0 
					 
					
						
						
							
							*** empty log message ***  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10544 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-08-23 22:44:48 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						c14e617f93 
					 
					
						
						
							
							(dpagaix): make sure of using $(EXEEXT) just to please automake (this  
						
						... 
						
						
						
						is aix-only code)
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10543 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-08-23 22:42:44 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						e55ce037ed 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10229 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-07-02 20:11:41 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						ecc382a9da 
					 
					
						
						
							
							*** empty log message ***  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9657 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-02-07 22:45:45 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						69dadc0db8 
					 
					
						
						
							
							(dpagaix): needs to be linked with ld, add an explicit command for  
						
						... 
						
						
						
						it.  from Ake Sandgren <ake@cs.umu.se >
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9656 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2001-02-07 22:45:37 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						04fb3dd9ba 
					 
					
						
						
							
							s/aix/irix/ is correct  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9369 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-12-11 15:27:32 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						7e78140308 
					 
					
						
						
							
							do not link with libroken on irix  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9327 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-12-10 08:19:39 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						2cc750ed57 
					 
					
						
						
							
							*** empty log message ***  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9114 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-10-08 21:45:44 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						9fcb211eb6 
					 
					
						
						
							
							link with roken on everything except aix, where apperently it fails.  
						
						... 
						
						
						
						reported by Ake Sandgren <ake@cs.umu.se >
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9092 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-10-02 06:33:52 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						cdddba94b4 
					 
					
						
						
							
							(LDADD): remove libroken.  we do not want this to link with libroken  
						
						... 
						
						
						
						since setenv will conflict with the setenv in libdce.  reported by Ake
Sandgren <ake@cs.umu.se >
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9091 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-10-02 06:24:03 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						dd993af961 
					 
					
						
						
							
							revert last change - we do not want this to depend on libroken  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9090 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-10-02 06:22:04 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						3e00ddf50d 
					 
					
						
						
							
							use esetenv  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9089 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-10-02 05:06:04 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						215597b043 
					 
					
						
						
							
							x  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8685 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-07-17 15:53:37 +00:00 
						 
				 
			
				
					
						
							
							
								Johan Danielsson 
							
						 
					 
					
						
						
							
						
						5baf067444 
					 
					
						
						
							
							set compiler flags  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8684 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-07-17 15:53:28 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						7ad123607e 
					 
					
						
						
							
							this probably wants to be here  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8541 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-07-04 11:55:49 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						e1a61145dd 
					 
					
						
						
							
							*** empty log message ***  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8507 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-07-01 19:19:57 +00:00 
						 
				 
			
				
					
						
							
							
								Assar Westerlund 
							
						 
					 
					
						
						
							
						
						408afcd320 
					 
					
						
						
							
							dce stuff, by way of From Ake Sandgren <ake@cs.umu.se>  
						
						... 
						
						
						
						git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8506 ec53bebd-3082-4978-b11e-865c3cabbd6b 
						
						
					 
					
						2000-07-01 19:19:31 +00:00