Commit Graph

998 Commits

Author SHA1 Message Date
Viktor Dukhovni
a71fa7b04d Silence LLVM compiler warnings
Should we simply drop FTP from the source at some point?
2015-03-04 19:44:20 -05:00
Love Hörnquist Åstrand
37afa01be3 rename roken base64, fixes #107 2014-08-22 20:57:24 -07:00
Jelmer Vernooij
70e43e9808 Fix some typos. 2014-04-25 02:42:17 +02:00
Nicolas Williams
a53f3a49e2 Fix unused variable warnings 2013-06-02 15:52:41 -05:00
Roland C. Dowdeswell
e8779d5d4a Add -Wshadow and deal with the warnings. 2012-02-21 11:17:55 +00:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Roland C. Dowdeswell
db484e73a2 Fix a few warnings. 2012-02-15 12:01:12 +00:00
Nicolas Williams
40a7d4b62f More fixes for -Werror (GCC 4.6 catches more stuff) 2011-11-02 23:20:55 -05:00
Love Hörnquist Åstrand
308d15615e drop krb4 2011-08-10 09:27:14 -07:00
Love Hörnquist Åstrand
47fee3d056 drop krb4 2011-08-10 09:26:31 -07:00
Love Hörnquist Åstrand
16eabf8e4c add an invalid protection level to the enum 2011-07-24 14:00:23 -07:00
Love Hörnquist Åstrand
7aaba443bc add NTMakefile and windows directories 2011-07-17 12:16:59 -07:00
Love Hörnquist Åstrand
09b07e9ef4 fix ifdef 2011-06-19 10:58:50 -07:00
Love Hörnquist Åstrand
625d29fc3e remove unused ifdef 2011-06-19 10:58:35 -07:00
Love Hörnquist Åstrand
749c112c31 only set IP_TOS on IPv4 sockets 2011-06-19 10:58:22 -07:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Thomas Klausner
db8e287e41 Use "Fl Fl" for long options.
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2011-05-21 11:54:14 -07:00
Love Hornquist Astrand
553ad48e38 remove label no longer used 2011-05-17 21:49:40 -07:00
Luke Howard
1a8bb5143c compile fix 2011-04-08 12:19:25 +10:00
Luke Howard
84f5aebc10 use gss_userok 2011-03-20 20:50:19 +11:00
Joerg Pulz
6f5b42957e add some more #ifdefs to compile on utmpx only systems
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2010-10-31 00:38:41 -07:00
Asanka Herath
d00f9984a5 Make roken build on windows
Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2009-11-24 21:42:02 -08:00
Love Hornquist Astrand
c6bbdb545b First drop of Windows build infrastructure from Secure Endpoints 2009-11-24 12:12:53 -08:00
Love Hornquist Astrand
20a06042da require local 2009-07-30 15:52:22 +02:00
Love Hornquist Astrand
11024751a5 make compile 2009-07-30 14:25:12 +02:00
Love Hornquist Astrand
00658426b2 c->c_name always set 2009-07-30 14:20:22 +02:00
Love Hornquist Astrand
98b23aa4c7 (sendrequest) local must be set [CID-45] 2009-07-30 14:17:45 +02:00
Love Hornquist Astrand
30b87b0633 Dont look too careful on local [CID-23] 2009-07-30 14:16:20 +02:00
Love Hornquist Astrand
fab281f465 (setnmap): make sure strchr returned a string [CID-65] 2009-07-30 13:00:34 +02:00
Love Hornquist Astrand
dfffe6d567 Check allocation error and free on error [CID-114] 2009-07-30 10:32:33 +02:00
Love Hornquist Astrand
3c053a2e09 fix up the paranoid code to make it work with ipv6. 2009-07-16 22:21:59 -07:00
Love Hörnquist Åstrand
d07832d6d7 rename ruserpass to ruserpassword to not collide with uclibc, prompted by [HEIMDAL-534]
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25331 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-15 23:07:07 +00:00
Love Hörnquist Åstrand
29fc07df5b add paranoid check for PORT and EPRT, make it default
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25330 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-15 22:18:25 +00:00
Love Hörnquist Åstrand
16b76d5cc0 add paranoid
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25329 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-07-15 22:18:13 +00:00
Love Hörnquist Åstrand
569ee5438c The max_ arguments are really "%.*s" format input paramaters, to make them into ints.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25253 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-28 01:21:08 +00:00
Love Hörnquist Åstrand
a619d66c48 Use S_ISREG
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25231 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-25 23:45:13 +00:00
Love Hörnquist Åstrand
1db1289c87 use S_ISDIR
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25230 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-05-25 23:45:03 +00:00
Love Hörnquist Åstrand
5e4d0f8798 make argument to cwd() const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25142 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 20:39:01 +00:00
Love Hörnquist Åstrand
9b4aafd0ec make argument to cwd() const
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25141 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 20:38:47 +00:00
Love Hörnquist Åstrand
22673e4df8 Hide home directory when chrooted or guest. From Ake Holmlund
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25129 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-25 16:25:36 +00:00
Love Hörnquist Åstrand
5f19fc6a9f use krb5_cc_new_unique()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25033 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:35 +00:00
Love Hörnquist Åstrand
5939a1b0f8 use krb5_cc_new_unique()
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25032 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:02:16 +00:00
Love Hörnquist Åstrand
1747257c60 don't set j to 0, since it never read again
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24924 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-03-22 17:24:15 +00:00
Love Hörnquist Åstrand
54d8d8504c Freeglob is not read again, just free.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24923 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-03-22 17:24:05 +00:00
Love Hörnquist Åstrand
f4680be3ce Plug memory leaks, from Roman Divacky.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24824 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-02-27 03:25:22 +00:00
Love Hörnquist Åstrand
a285f3339e drop krb4
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24534 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-27 22:52:56 +00:00
Love Hörnquist Åstrand
580ba0e781 remove krb4
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24500 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:10:19 +00:00
Love Hörnquist Åstrand
2038ffd351 drop krbv4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24496 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:28 +00:00
Love Hörnquist Åstrand
a21969d84d drop krb4 support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24495 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-26 01:09:16 +00:00
Love Hörnquist Åstrand
0bed824d0f drop RCSID
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24426 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-01-25 00:42:06 +00:00