Commit Graph

46 Commits

Author SHA1 Message Date
Luke Howard
014f16883c libhcrypto: UI_UTIL_FLAG_VERIFY_SILENT 2018-12-30 15:39:49 -06:00
Roland C. Dowdeswell
cc47c8fa7b Turn on -Wextra -Wno-sign-compare -Wno-unused-paramter and fix issues.
We turn on a few extra warnings and fix the fallout that occurs
when building with --enable-developer.  Note that we get different
warnings on different machines and so this will be a work in
progress.  So far, we have built on NetBSD/amd64 5.99.64 (which
uses gcc 4.5.3) and Ubuntu 10.04.3 LTS (which uses gcc 4.4.3).

Notably, we fixed

	1.  a lot of missing structure initialisers,

	2.  unchecked return values for functions that glibc
	    marks as __attribute__((warn-unused-result)),

	3.  made minor modifications to slc and asn1_compile
	    which can generate code which generates warnings,
	    and

	4.  a few stragglers here and there.

We turned off the extended warnings for many programs in appl/ as
they are nearing the end of their useful lifetime, e.g.  rsh, rcp,
popper, ftp and telnet.

Interestingly, glibc's strncmp() macro needed to be worked around
whereas the function calls did not.

We have not yet tried this on 32 bit platforms, so there will be
a few more warnings when we do.
2012-02-20 19:45:41 +00:00
Love Hornquist Astrand
0879b9831a remove trailing whitespace 2011-05-21 11:57:31 -07:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Andrew Bartlett
d9f4d53dda s4:heimdal Use correct variable to advance past -- options in kpasswd
This bug was introduced when kpasswd was migrated to a local getarg()
call, in Heimdal commit 7dd146072c

Andrew Bartlett

Signed-off-by: Love Hornquist Astrand <lha@h5l.org>
2010-03-27 01:20:52 -07:00
Love Hornquist Astrand
7dd146072c switch to getarg directly 2009-11-23 07:36:34 -08:00
Love Hörnquist Åstrand
5c0fc04d81 use krb5_cc_new_unique, use constants for cache types
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@25050 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-04-03 04:05:48 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
979ac09247 return exit_value
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23508 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-08-11 10:00:39 +00:00
Love Hörnquist Åstrand
ece5f9603e Make krb5_get_init_creds_opt_free take a context argument.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@19078 ec53bebd-3082-4978-b11e-865c3cabbd6b
2006-11-20 18:12:41 +00:00
Love Hörnquist Åstrand
8e0cc6db4d allow specifying a credential cache to use for the admin principal
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14477 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-01-05 16:08:03 +00:00
Love Hörnquist Åstrand
17083d8556 use krb5_set_password_using_ccache
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13911 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-06-02 19:30:38 +00:00
Johan Danielsson
26457b7135 replace krb5_free_creds_contents by krb5_free_cred_contents
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13790 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-04-25 19:25:35 +00:00
Love Hörnquist Åstrand
bab9752256 (change_password): remove extra free
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13660 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-03-31 14:01:55 +00:00
Love Hörnquist Åstrand
9e29b1f854 (change_password): handle that printf(".*s", 0, (void*)NULL); doesn't
work on solaris


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13323 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-02-10 20:28:26 +00:00
Love Hörnquist Åstrand
5d190295aa add context argument to krb5_get_init_creds_opt_alloc
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12783 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-08 15:28:20 +00:00
Love Hörnquist Åstrand
54fc57ccb5 s/des_read_pw_string/UI_UTIL_read_pw_string/
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12753 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 09:37:03 +00:00
Love Hörnquist Åstrand
61e14619de use krb5_get_init_creds_opt_alloc/krb5_get_init_creds_opt_free
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12737 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-09-03 00:31:42 +00:00
Love Hörnquist Åstrand
56fe7f8941 handle setting passwords for multiple principals at the same time
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12273 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-05-13 13:06:10 +00:00
Love Hörnquist Åstrand
f14efa0284 update c
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12267 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-05-12 16:54:14 +00:00
Love Hörnquist Åstrand
fa764fe97e use krb5_set_password
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12263 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-05-12 16:49:26 +00:00
Assar Westerlund
f70acdb382 improve error message printing
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10746 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-09-27 01:29:40 +00:00
Assar Westerlund
633782864b (main): handle krb5_init_context failure consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9443 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-12-31 08:05:03 +00:00
Assar Westerlund
2d4837b225 print usage consistently
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8733 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-21 04:37:44 +00:00
Assar Westerlund
fb07fdd54a (main): make sure the ticket is not forwardable and not proxiable
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7832 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-01-28 03:19:32 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Assar Westerlund
8f8b7c05c8 (main): don't print any error if reading the password was interrupted
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6968 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-09-14 21:48:04 +00:00
Johan Danielsson
daebb89321 clarify messages from server
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6878 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-08-27 09:01:21 +00:00
Assar Westerlund
ff6ba1ac43 (main): use krb5_program_setup and print_version
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5924 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-04-11 00:01:16 +00:00
Assar Westerlund
fc1956b05f new arg_printusage
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@5130 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-08-18 21:17:01 +00:00
Assar Westerlund
31a1f7d4ca detect bad password. use krb5_err.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4321 ec53bebd-3082-4978-b11e-865c3cabbd6b
1998-01-21 00:32:57 +00:00
Assar Westerlund
b3712d39f4 less warnings
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3750 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-11-02 04:07:03 +00:00
Assar Westerlund
e624e0c3a4 (main): check number of arguments
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3421 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-09-07 23:34:53 +00:00
Assar Westerlund
da16abb9b3 removed `-p'
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@3120 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-08-24 10:40:38 +00:00
Assar Westerlund
6e854a3679 Use krb5_change_password
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2915 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-08-11 17:12:54 +00:00
Assar Westerlund
85b631b8f5 converted to getarg and get_init_creds
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2747 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-08-07 22:37:07 +00:00
Assar Westerlund
28bcc56971 new style of krb5_free_creds
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2738 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-08-07 20:26:33 +00:00
Assar Westerlund
cd8632c2f6 use sequence numbers
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2608 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-24 08:07:07 +00:00
Assar Westerlund
13e484addf free some memory
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2563 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-23 23:06:33 +00:00
Johan Danielsson
23976f2cb4 Cast to char*
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2508 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-22 18:39:17 +00:00
Assar Westerlund
8be775f311 restructured code.
better report on krb-error
break if des_read_pw_string() != 0


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2495 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-20 14:26:09 +00:00
Johan Danielsson
aebebed645 Ask for password before call to get_in_tkt.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2489 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-20 05:35:02 +00:00
Johan Danielsson
4232e68fc0 Avoid using non-standard struct names.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2485 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-20 04:35:42 +00:00
Assar Westerlund
53f8604cdc restructured and implemented some functionality
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2425 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-18 00:52:20 +00:00
Assar Westerlund
0a2e34960c non-working kpasswd
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@2402 ec53bebd-3082-4978-b11e-865c3cabbd6b
1997-07-17 18:27:07 +00:00